From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: kbuild test robot <lkp@intel.com>, Sagi Grimberg <sagig@mellanox.com>
Cc: kbuild-all@01.org, "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
target-devel@vger.kernel.org, linux-rdma@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 09/12] iser-target: Convert to new CQ API
Date: Thu, 25 Feb 2016 10:53:45 +0200 [thread overview]
Message-ID: <56CEC119.9000702@dev.mellanox.co.il> (raw)
In-Reply-To: <201602250552.AzC8mEaU%fengguang.wu@intel.com>
> Hi Christoph,
>
> [auto build test ERROR on target/master]
> [also build test ERROR on v4.5-rc5 next-20160224]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Sagi-Grimberg/iser-target-patches-for-4-6/20160225-012959
> base: https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
> config: s390-allmodconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=s390
>
> Note: the linux-review/Sagi-Grimberg/iser-target-patches-for-4-6/20160225-012959 HEAD 587105db403a346e5e1b003873f189e0d174efe5 builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_beacon_done':
>>> drivers/infiniband/ulp/isert/ib_isert.c:3231:2: error: too few arguments to function 'isert_print_wc'
> isert_print_wc(wc);
> ^
> drivers/infiniband/ulp/isert/ib_isert.c:1541:1: note: declared here
> isert_print_wc(struct ib_wc *wc, const char *type)
> ^
OK, that's my fault...
Nic, care to fold this in the patch?
--
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp/isert/ib_isert.c
index 76ff338..4269f22 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -3228,7 +3228,7 @@ isert_beacon_done(struct ib_cq *cq, struct ib_wc *wc)
{
struct isert_conn *isert_conn = wc->qp->qp_context;
- isert_print_wc(wc);
+ isert_print_wc(wc, "beacon");
isert_info("conn %p completing wait_comp_err\n", isert_conn);
complete(&isert_conn->wait_comp_err);
--
Patch 12/12 drops this anyways...
next prev parent reply other threads:[~2016-02-25 8:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 17:23 [PATCH 00/12] iser target patches for 4.6 Sagi Grimberg
2016-02-24 17:23 ` [PATCH 01/12] iser-target: Fix identification of login rx descriptor type Sagi Grimberg
2016-02-24 17:24 ` [PATCH 03/12] iser-target: Separate flows for np listeners and connections cma events Sagi Grimberg
2016-02-24 17:24 ` [PATCH 04/12] iser-target: Rework connection termination Sagi Grimberg
2016-02-24 17:24 ` [PATCH 07/12] iser-target: Remove ISER_RECV_DATA_SEG_LEN Sagi Grimberg
2016-02-24 17:24 ` [PATCH 10/12] iser-target: Kill struct isert_rdma_wr Sagi Grimberg
2016-02-24 17:24 ` [PATCH 11/12] iser-target: Kill the ->isert_cmd back pointer in struct iser_tx_desc Sagi Grimberg
2016-02-24 17:24 ` [PATCH 12/12] iser-target: Use ib_drain_qp Sagi Grimberg
[not found] ` <1456334649-21437-13-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-24 17:28 ` Sagi Grimberg
2016-02-24 18:08 ` kbuild test robot
[not found] ` <201602250232.0MaJNmx5%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-25 8:49 ` Sagi Grimberg
2016-02-27 23:36 ` Nicholas A. Bellinger
[not found] ` <1456616190.1750.54.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2016-02-28 10:54 ` Sagi Grimberg
2016-03-23 7:48 ` Christoph Hellwig
2016-03-31 4:24 ` Nicholas A. Bellinger
2016-04-03 13:15 ` sagig
[not found] ` <1456334649-21437-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-24 17:23 ` [PATCH 02/12] iser-target: Add new state ISER_CONN_BOUND to isert_conn Sagi Grimberg
2016-02-24 17:24 ` [PATCH 05/12] iser-target: Remove redundant wait in release_conn Sagi Grimberg
2016-02-24 17:24 ` [PATCH 06/12] iser-target: Remove impossible condition from isert_wait_conn Sagi Grimberg
2016-02-24 17:24 ` [PATCH 08/12] iser-target: Split and properly type the login buffer Sagi Grimberg
2016-02-24 17:24 ` [PATCH 09/12] iser-target: Convert to new CQ API Sagi Grimberg
2016-02-24 22:01 ` kbuild test robot
2016-02-25 8:53 ` Sagi Grimberg [this message]
2016-02-26 6:03 ` Nicholas A. Bellinger
2016-02-24 17:26 ` [PATCH 00/12] iser target patches for 4.6 Sagi Grimberg
2016-02-26 5:59 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CEC119.9000702@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=hch@lst.de \
--cc=kbuild-all@01.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox