Re: [PATCH 1/5] IB/isert: Remove ISER_RECV_DATA_SEG_LEN

Sagi Grimberg
2016-02-22T15:41:12Z

>>>> @@ -92,7 +90,7 @@ enum iser_conn_state {
>>>> struct iser_rx_desc {
>>>> struct iser_ctrl iser_header;
>>>> struct iscsi_hdr iscsi_header;
>>>> - char data[ISER_RECV_DATA_SEG_LEN];
>>>> + char data[ISCSI_DEF_MAX_RECV_SEG_LEN];
>>>> u64 dma_addr;
>>>> struct ib_sge rx_sg;
>>>> char pad[ISER_RX_PAD_SIZE];
>>
>> BTW that pad is probably just c&p from the initiator, has nothing to do here
>
> The way the RX descriptors work is rather odd in many ways. It's on
> my todo list to investigate and rework them.

Hey Christoph and Or,

Indeed the way RX descriptors are handled in isert has a lot of room
for cleanups (among other things...), its on my todo list as well. I
didn't have a lot of time to spend on isert lately but I do plan to
to resume the work there soon enough.

Christoph,
I took your patches for testing and evaluation (on top of some fixes
from Jenny I have in the pipe), basic functionality seems to work just
fine, I'll make sure to run some more tests and review the code.

Thanks!