Re: [PATCH 1/5] IB/isert: Remove ISER_RECV_DATA_SEG_LEN

Christoph Hellwig
2016-02-22T15:05:58Z

On Mon, Feb 22, 2016 at 04:57:50PM +0200, Or Gerlitz wrote:
> >> @@ -92,7 +90,7 @@ enum iser_conn_state {
> >> struct iser_rx_desc {
> >> struct iser_ctrl iser_header;
> >> struct iscsi_hdr iscsi_header;
> >> - char data[ISER_RECV_DATA_SEG_LEN];
> >> + char data[ISCSI_DEF_MAX_RECV_SEG_LEN];
> >> u64 dma_addr;
> >> struct ib_sge rx_sg;
> >> char pad[ISER_RX_PAD_SIZE];
>
> BTW that pad is probably just c&p from the initiator, has nothing to do here

The way the RX descriptors work is rather odd in many ways. It's on
my todo list to investigate and rework them.