Re: [PATCH 1/5] IB/isert: Remove ISER_RECV_DATA_SEG_LEN

Or Gerlitz
2016-02-22T14:55:03Z

On Mon, Feb 22, 2016 at 3:49 PM, Christoph Hellwig <hch@lst.de> wrote:

> @@ -36,9 +36,7 @@
> -#define ISER_RECV_DATA_SEG_LEN 8192

Sagi,

Can you please explain WW (When & Why) we changed this from 128 bytes
to 8192 bytes?!! do we use 8000++ bytes for every RX descriptor or
this is nowadays only for the login phase? what's the trick?

Or.

> @@ -92,7 +90,7 @@ enum iser_conn_state {
> struct iser_rx_desc {
> struct iser_ctrl iser_header;
> struct iscsi_hdr iscsi_header;
> - char data[ISER_RECV_DATA_SEG_LEN];
> + char data[ISCSI_DEF_MAX_RECV_SEG_LEN];
> u64 dma_addr;
> struct ib_sge rx_sg;
> char pad[ISER_RX_PAD_SIZE];
> --