Re: [PATCH 09/12] iser-target: Convert to new CQ API

Sagi Grimberg
2016-02-25T08:53:45Z

> Hi Christoph,
>
> [auto build test ERROR on target/master]
> [also build test ERROR on v4.5-rc5 next-20160224]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Sagi-Grimberg/iser-target-patches-for-4-6/20160225-012959
> base: https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
> config: s390-allmodconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=s390
>
> Note: the linux-review/Sagi-Grimberg/iser-target-patches-for-4-6/20160225-012959 HEAD 587105db403a346e5e1b003873f189e0d174efe5 builds fine.
> It only hurts bisectibility.
>
> All errors (new ones prefixed by >>):
>
> drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_beacon_done':
>>> drivers/infiniband/ulp/isert/ib_isert.c:3231:2: error: too few arguments to function 'isert_print_wc'
> isert_print_wc(wc);
> ^
> drivers/infiniband/ulp/isert/ib_isert.c:1541:1: note: declared here
> isert_print_wc(struct ib_wc *wc, const char *type)
> ^

OK, that's my fault...

Nic, care to fold this in the patch?

--
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp/isert/ib_isert.c
index 76ff338..4269f22 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -3228,7 +3228,7 @@ isert_beacon_done(struct ib_cq *cq, struct ib_wc *wc)
{
struct isert_conn *isert_conn = wc->qp->qp_context;

- isert_print_wc(wc);
+ isert_print_wc(wc, "beacon");

isert_info("conn %p completing wait_comp_err\n", isert_conn);
complete(&isert_conn->wait_comp_err);
--

Patch 12/12 drops this anyways...