Re: [PATCH 09/12] iser-target: Convert to new CQ API

Nicholas A. Bellinger
2016-02-26T06:03:52Z

On Wed, 2016-02-24 at 19:24 +0200, Sagi Grimberg wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Use the workqueue based CQ type similar to what isert was using previously,
> and properly split up the completion handlers.
>
> Note that this also takes special care to handle the magic login WRs
> separately, and also renames the submission functions so that it's clear
> that they are only to be used for the login buffers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> [sagig: added iscsi conn reinstatement in non-flush
> error completions and added error completion type print]
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 405 +++++++++++++-------------------
> drivers/infiniband/ulp/isert/ib_isert.h | 22 +-
> 2 files changed, 184 insertions(+), 243 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index ac3e80c55965..76ff3388890d 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c

<SNIP>

> @@ -3303,14 +3224,26 @@ isert_wait4cmds(struct iscsi_conn *conn)
> }
>
> static void
> +isert_beacon_done(struct ib_cq *cq, struct ib_wc *wc)
> +{
> + struct isert_conn *isert_conn = wc->qp->qp_context;
> +
> + isert_print_wc(wc);
> +
> + isert_info("conn %p completing wait_comp_err\n", isert_conn);
> + complete(&isert_conn->wait_comp_err);
> +}
> +

drivers/infiniband/ulp/isert/ib_isert.c: In function ‘isert_beacon_done’:
drivers/infiniband/ulp/isert/ib_isert.c:3221:2: error: too few arguments to function ‘isert_print_wc’
drivers/infiniband/ulp/isert/ib_isert.c:1538:1: note: declared here
make[4]: *** [drivers/infiniband/ulp/isert/ib_isert.o] Error 1
make[3]: *** [drivers/infiniband/ulp/isert] Error 2

Fixing up the build breakage here.