From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Christoph Hellwig <hch@lst.de>, jlbec@evilplan.org
Cc: balbi@kernel.org, laurent.pinchart@ideasonboard.com,
target-devel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-rdma@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] configfs: switch ->default groups to a linked list
Date: Sun, 28 Feb 2016 12:58:42 +0200 [thread overview]
Message-ID: <56D2D2E2.3000200@dev.mellanox.co.il> (raw)
In-Reply-To: <1456490031-7132-1-git-send-email-hch@lst.de>
On 26/02/2016 14:33, Christoph Hellwig wrote:
> Replace the current NULL-terminated array of default groups with a linked
> list. This gets rid of lots of nasty code to size and/or dynamically
> allocate the array.
>
> While we're at it also provide a conveniant helper to remove the default
> groups.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Nice!
> -As a consequence of this, default_groups cannot be removed directly via
> +As a consequence of this, default groups cannot be removed directly via
> rmdir(2). They also are not considered when rmdir(2) on the parent
> group is checking for children.
>
What's changed here?
Other than that, looks good
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
next prev parent reply other threads:[~2016-02-28 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 12:33 [PATCH] configfs: switch ->default groups to a linked list Christoph Hellwig
2016-02-26 12:43 ` Felipe Balbi
2016-02-27 23:22 ` Nicholas A. Bellinger
2016-03-11 2:19 ` Doug Ledford
2016-02-28 10:58 ` Sagi Grimberg [this message]
[not found] ` <56D2D2E2.3000200-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-28 13:09 ` Christoph Hellwig
[not found] ` <1456490031-7132-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-03-05 21:40 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D2D2E2.3000200@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=balbi@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox