Re: [PATCH 05/13] IB/core: add a simple MR pool

Bart Van Assche
2016-03-02T15:22:43Z

On 03/02/16 01:15, Christoph Hellwig wrote:
> On Wed, Mar 02, 2016 at 08:18:14AM +0530, Parav Pandit wrote:
>>> struct list_head xrcd_list;
>>> +
>>> + spinlock_t mr_lock;
>>> + int mrs_used;
>>> +
>>
>> Can you please add the comment for mr_lock as requested by the
>> checkpatch script?
>
> No. checkpath is asking for silly things (and apparently this one
> is so silly it doesn't even ask for it by default).
>
>> Also you might want to consider adding this field after recv_cq so
>> that we find mr_lock and used count in single cache line along with
>> other data for the qp?
>
> That sounds useful, I'll look into it.

Hello Christoph,

With the approach of V2 of this patch series mr_lock and the MR pool
list head exist in different structures which is unfortunate. How about
introducing a new structure for the MR pool list head and mr_lock? An
additional advantage of this approach is that it would allow to move the
initialization of both structure members into ib_mr_pool_init().

Bart.