Re: [PATCH 05/13] IB/core: add a simple MR pool

Parav Pandit
2016-03-02T02:48:14Z

Hi Christoph,

On Sat, Feb 27, 2016 at 11:40 PM, Christoph Hellwig <hch@lst.de> wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 267f11e..1e68dae 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1408,6 +1408,10 @@ struct ib_qp {
> struct ib_srq *srq;
> struct ib_xrcd *xrcd; /* XRC TGT QPs only */
> struct list_head xrcd_list;
> +
> + spinlock_t mr_lock;
> + int mrs_used;
> +

Can you please add the comment for mr_lock as requested by the
checkpatch script?

Also you might want to consider adding this field after recv_cq so
that we find mr_lock and used count in single cache line along with
other data for the qp?