Re: [PATCH 13/13] IB/isert: RW API WIP

Christoph Hellwig
2016-02-28T16:04:34Z

On Sun, Feb 28, 2016 at 03:57:15PM +0200, Sagi Grimberg wrote:
>
>> drivers/infiniband/ulp/isert/ib_isert.c | 855 ++++++--------------------------
>> drivers/infiniband/ulp/isert/ib_isert.h | 70 +--
>> 2 files changed, 161 insertions(+), 764 deletions(-)
>
> Ha! 603 LOC deletion!
>
> I plan to incorporate the signature stuff into the rdma_rw API
> and then we can reduce it even further! It'll take me some time
> though...

The whole series including the CQ API actually removes more code
than it adds even with a single consumer.