Re: [PATCH 05/13] IB/core: add a simple MR pool

Christoph Hellwig
2016-03-02T09:15:54Z

On Wed, Mar 02, 2016 at 08:18:14AM +0530, Parav Pandit wrote:
> > struct list_head xrcd_list;
> > +
> > + spinlock_t mr_lock;
> > + int mrs_used;
> > +
>
> Can you please add the comment for mr_lock as requested by the
> checkpatch script?

No. checkpath is asking for silly things (and apparently this one
is so silly it doesn't even ask for it by default).

> Also you might want to consider adding this field after recv_cq so
> that we find mr_lock and used count in single cache line along with
> other data for the qp?

That sounds useful, I'll look into it.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html