Re: [PATCH RESEND] qib:Fix concurrent access in the function, qib_init_iba6120_funcs

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

[ Dropping linux-kernel, they already know what I'm going to write here,
this is mainly for the linux-rdma folks ]

On 03/07/2016 03:49 PM, Leon Romanovsky wrote:
> On Mon, Mar 07, 2016 at 04:34:04PM +0000, Marciniszyn, Mike wrote:
>>> This fixes concurrent access in the function, qib_init_iba6120_funcs by locking
>>> around the calls to when setting up f_sendctrl and f_set_armlauch function
>>> pointers to the functions, sendctrl_6120_mod qib_set_6120_armlaunch due to
>>> these functions needing to have their caller to hold the spinlock that is part of
>>> the qib_ibport pointer they are using and due to the lock not being held by
>>> higher up functions in the caller stack we need to hold it in qib_init_iba6210 to
>>> avoid conncurrent access when setting up these function pointers.
>>>
>>
>> I'm not sure I agree.
>>
>> static struct pci_driver qib_driver = {
>>         .name = QIB_DRV_NAME,
>>         .probe = qib_init_one,
>>         .remove = qib_remove_one,
>>         .id_table = qib_pci_tbl,
>>         .err_handler = &qib_pci_err_handler,
>> };
>>
>> The only caller is the probe function, which naturally protects since the device cannot be used until the probe returns.
>>
>> Are you actually having an issue with this older version of a qib card?
> 
> IMHO no,
> The author is famous developer - Nick Krause [1].
> 
> [1]
> http://news.softpedia.com/news/Malevolent-Developer-Trolls-Linux-Kernel-Development-with-Lots-of-Broken-Patches-453709.shtml

Guys, please quit feeding the trolls.  I reviewed Nick's patches when I
first took this job.  After deciding that they had a > 50% wrongness
value (meaning, even though the patches are trivial, more than half of
them are *still* wrong on average), he is now in my killfile.  If you
truly feel the need to review his stuff, be aware you will have to
submit it yourself for me to even consider it as his patches aren't even
allowed on the patchworks server (not my doing, it was this way when I
took this job).


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]