From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [patch] ib_srpt: fix a WARN_ON() message Date: Fri, 18 Mar 2016 18:17:20 -0700 Message-ID: <56ECA8A0.5060502@sandisk.com> References: <20160318054159.GE2111@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160318054159.GE2111@mwanda> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter , Doug Ledford Cc: Sean Hefty , Hal Rosenstock , Nicholas Bellinger , Sagi Grimberg , Alex Estrin , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 03/17/16 22:41, Dan Carpenter wrote: > The first argument of WARN_ON() is a condition, so it means the warning > message here will just be the name without the ->qp_num information. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > index 1d13090..0bd3cb2 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc) > if (srpt_set_ch_state(ch, CH_DISCONNECTED)) > schedule_work(&ch->release_work); > else > - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num); > + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num); > } > } Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html