Re: [patch] ib_srpt: fix a WARN_ON() message

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]

On 3/18/2016 9:17 PM, Bart Van Assche wrote:
> On 03/17/16 22:41, Dan Carpenter wrote:
>> The first argument of WARN_ON() is a condition, so it means the warning
>> message here will just be the name without the ->qp_num information.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>>
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 1d13090..0bd3cb2 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct
>> ib_cq *cq, struct ib_wc *wc)
>>           if (srpt_set_ch_state(ch, CH_DISCONNECTED))
>>               schedule_work(&ch->release_work);
>>           else
>> -            WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> +            WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
>>       }
>>   }
> 
> Reviewed-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

Thanks, applied.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]