From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [patch] ib_srpt: fix a WARN_ON() message Date: Mon, 21 Mar 2016 16:15:19 -0400 Message-ID: <56F05657.6050608@redhat.com> References: <20160318054159.GE2111@mwanda> <56ECA8A0.5060502@sandisk.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G5aJQWHVP3SGx2m7msMicfQ0kXFHMKm6q" Return-path: In-Reply-To: <56ECA8A0.5060502-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche , Dan Carpenter Cc: Sean Hefty , Hal Rosenstock , Nicholas Bellinger , Sagi Grimberg , Alex Estrin , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G5aJQWHVP3SGx2m7msMicfQ0kXFHMKm6q Content-Type: multipart/mixed; boundary="ktSfpcNudElXJL5pldW1cUDbgXIhutu4i" From: Doug Ledford To: Bart Van Assche , Dan Carpenter Cc: Sean Hefty , Hal Rosenstock , Nicholas Bellinger , Sagi Grimberg , Alex Estrin , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Message-ID: <56F05657.6050608-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Subject: Re: [patch] ib_srpt: fix a WARN_ON() message References: <20160318054159.GE2111@mwanda> <56ECA8A0.5060502-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> In-Reply-To: <56ECA8A0.5060502-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> --ktSfpcNudElXJL5pldW1cUDbgXIhutu4i Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/18/2016 9:17 PM, Bart Van Assche wrote: > On 03/17/16 22:41, Dan Carpenter wrote: >> The first argument of WARN_ON() is a condition, so it means the warnin= g >> message here will just be the name without the ->qp_num information. >> >> Signed-off-by: Dan Carpenter >> >> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c >> b/drivers/infiniband/ulp/srpt/ib_srpt.c >> index 1d13090..0bd3cb2 100644 >> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c >> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c >> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct >> ib_cq *cq, struct ib_wc *wc) >> if (srpt_set_ch_state(ch, CH_DISCONNECTED)) >> schedule_work(&ch->release_work); >> else >> - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num); >> + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num); >> } >> } >=20 > Reviewed-by: Bart Van Assche Thanks, applied. --ktSfpcNudElXJL5pldW1cUDbgXIhutu4i-- --G5aJQWHVP3SGx2m7msMicfQ0kXFHMKm6q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJW8FZXAAoJELgmozMOVy/deoAQAKjOmuQ1Qk58TJ2j9iT6sNCs zkbkysKEBFcV/QqJbeDUwxklXYlKoARkvEpRKzBF1Q5ncDKfyQ3f3Nhk0uAfCkcQ 9T1AHDlTWL/nQEfT+qQj7j8Q/DgvbTkpKzpZTSglEnf2UpxWi4EQOni3co8yDZhH c2vYVVK+gPUOETld4pKUZf6kwjjO2mvgUXMKVr4tLS5pHoJ+rH3LIqD2P0A0PlF8 LHyuRBiSOLPsIgsSL4GTTKyzyEewSo0xDYOs01kYtLcUxnq43+C8m1OQ7S0N7yhE lfHY2JvSHCEdGVwhz7I0M+vmZEXSf08yrKl179lzu3X2b5y/HH0c051KoRQUSXP0 b7v00ldP9C2EO9dPhsjSFcAWB80tRw7WaY4bK4R/G4vU4YNb88xj6ykcC5J0iaCc xGdBzCmkXS06EJxNmpMMMgl/iMmvZ5gMZZWulBg/wstsa27FM9aX1MdFR7P4l+T5 UC8/lUy8gydsf/5UUgT6LGVASMhUetPBKGQkNNbzEdtBKLuT8kX6OkEUyl2zG7DC QOyv8htfYTMhqcdyBVvUN46XyTDmd/gTg2pa2C9QrbYQltL6Rw9vUMec2f+47nkZ RbteAcrt4Dui6ZuwuFbs8ByCZMVEa7PYjo2IEl3Yv2XdpgL2ZD7pxyvSzhiWJc/J raJUVyCSlKUuSxOwcp0T =hCvc -----END PGP SIGNATURE----- --G5aJQWHVP3SGx2m7msMicfQ0kXFHMKm6q-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html