From: Sagi Grimberg <sagi@grimberg.me>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro
Date: Sun, 20 Nov 2022 13:52:23 +0200 [thread overview]
Message-ID: <56a99d68-eaed-7f8a-8371-a2f6a1f2acd3@grimberg.me> (raw)
In-Reply-To: <20221116094535.138298-1-mlombard@redhat.com>
title prefix should be:
iser-target: use the...
> Use the proper macro to get the current_stage value.
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index b360a1527cd1..75404885cf98 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
> * login request PDU.
> */
> login->leading_connection = (!login_req->tsih) ? 1 : 0;
> - login->current_stage =
> - (login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
> - >> 2;
> + login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
> + login_req->flags);
> login->version_min = login_req->min_version;
> login->version_max = login_req->max_version;
> memcpy(login->isid, login_req->isid, 6);
Acked-by: Sagi Grimberg <sagi@grimberg.me>
next prev parent reply other threads:[~2022-11-20 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:45 [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro Maurizio Lombardi
2022-11-17 17:31 ` Mike Christie
2022-11-20 11:52 ` Sagi Grimberg [this message]
2022-11-21 19:01 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56a99d68-eaed-7f8a-8371-a2f6a1f2acd3@grimberg.me \
--to=sagi@grimberg.me \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mlombard@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox