From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH] ib_srpt: Add missing ioctx->buf + ->dma alloc_session_cb init Date: Mon, 4 Apr 2016 11:40:03 -0700 Message-ID: <5702B503.1060006@sandisk.com> References: <1459794233-19187-1-git-send-email-nab@linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1459794233-19187-1-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Nicholas A. Bellinger" , target-devel Cc: linux-rdma , Sagi Grimberg , Doug Ledford List-Id: linux-rdma@vger.kernel.org On 04/04/2016 11:28 AM, Nicholas A. Bellinger wrote: > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > index 0bd3cb2..c4e0a0a 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -1266,7 +1266,9 @@ static struct srpt_send_ioctx *srpt_get_send_ioctx(struct srpt_rdma_ch *ch) > { > struct se_session *se_sess; > struct srpt_send_ioctx *ioctx; > - int tag; > + void *buf; > + dma_addr_t dma; > + int tag, index; > > BUG_ON(!ch); > se_sess = ch->sess; > @@ -1277,12 +1279,19 @@ static struct srpt_send_ioctx *srpt_get_send_ioctx(struct srpt_rdma_ch *ch) > return NULL; > } > ioctx = &((struct srpt_send_ioctx *)se_sess->sess_cmd_map)[tag]; > + buf = ioctx->ioctx.buf; > + dma = ioctx->ioctx.dma; > + index = ioctx->ioctx.index; > + > memset(ioctx, 0, sizeof(struct srpt_send_ioctx)); > ioctx->ch = ch; > spin_lock_init(&ioctx->spinlock); > ioctx->state = SRPT_STATE_NEW; > init_completion(&ioctx->tx_done); > > + ioctx->ioctx.buf = buf; > + ioctx->ioctx.dma = dma; > + ioctx->ioctx.index = index; > ioctx->cmd.map_tag = tag; > > return ioctx; > @@ -1961,6 +1970,24 @@ static void srpt_free_ch(struct kref *kref) > kfree(ch); > } These assignments should happen once, namely just after I/O context allocation, instead of performing these assignments during every srpt_get_send_ioctx() call. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html