linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] IB/mlx5: Expose correct max_sge_rd limit
Date: Thu, 7 Apr 2016 10:05:24 +0300	[thread overview]
Message-ID: <570606B4.5040402@grimberg.me> (raw)
In-Reply-To: <20160401000426.GF2670-2ukJVAZIZ/Y@public.gmane.org>



On 01/04/16 03:04, Leon Romanovsky wrote:
> On Thu, Mar 31, 2016 at 07:03:25PM +0300, Sagi Grimberg wrote:
>> mlx5 devices (Connect-IB, ConnectX-4, ConnectX-4-LX) has a limitation
>> where rdma read work queue entries cannot exceed 512 bytes.
>> A rdma_read wqe needs to fit in 512 bytes:
>> - wqe control segment (16 bytes)
>> - rdma segment (16 bytes)
>> - scatter elements (16 bytes each)
>>
>> So max_sge_rd should be: (512 - 16 - 16) / 16 = 30.
>>
>> Reported-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
>> Tested-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
>> Signed-off-by: Sagi Grimberg <sagig-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
>
> Thanks Sagi,
>
> Excellent catch, the same as in commit: a5e4ba334e2
> ("mlx4: Expose correct max_sge_rd limit")
>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Doug, this is stable material, can we get it to 4.6-rc
and place a stable tag on it?

Thanks,
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-04-07  7:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 16:03 [PATCH] IB/mlx5: Expose correct max_sge_rd limit Sagi Grimberg
     [not found] ` <1459440205-25208-1-git-send-email-sagig-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-01  0:04   ` Leon Romanovsky
     [not found]     ` <20160401000426.GF2670-2ukJVAZIZ/Y@public.gmane.org>
2016-04-07  7:05       ` Sagi Grimberg [this message]
     [not found]         ` <570606B4.5040402-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-28 14:53           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570606B4.5040402@grimberg.me \
    --to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).