Re: T10 PI offloading seems to be broken in iser/isert in 4.5/4.6-rc

Christoph Hellwig
2016-04-09T00:14:56Z

On Fri, Apr 08, 2016 at 04:48:10PM -0700, Nicholas A. Bellinger wrote:
> It looks like the isert_set_dif_domain() assignments of
> ib_sig_domain->sig.dif.* from dev->dev_attrib.block_size + friends is
> being zeroed before making it into mlx5_ib_post_send() ->
> IB_WR_REG_SIG_MR -> set_sig_umr_wr() -> set_sig_data_segment().

>From my limited understanding that's not the case, even if the weird
printk about the bad block size might suggest it.

I think what we have is the TARGET_PROT_DIN_INSERT /
TARGET_PROT_DOUT_STRIP case (probably the first), and thus
sig_attrs->mem.sig_type is set to IB_SIG_TYPE_NONE, but for some
reason the prot pointer is set, which will lead to this misleading
printk.

Does anyone know a recent working version of T10 PI in isert? There
aren't any recent-ish changes that look related.