From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 11/12] IB/core: add RW API support for signature MRs
Date: Tue, 19 Apr 2016 21:46:08 +0300 [thread overview]
Message-ID: <57167CF0.5090405@grimberg.me> (raw)
In-Reply-To: <20160419182950.GC989-jcswGhMUV9g@public.gmane.org>
>>> In isert if the we have a single sg entry, we use the local_dma_lkey
>>> just so we can skip a registration (also for protection sg), perhaps
>>> rdma_rw_init_one_mr can do this optimization too?
>>
>> Can't more than a single SG can be packed into a WR? Ideally this
>> common code should try and max out the SG entries before falling back
>> to using a WR?
>
> Mellanox signature MRs don't support registering more than a single SGE.
It can theoretically, but large sg lists can potentially
clog up the send queue in this case, and it would not perform
as well as in the current scheme the driver has a smart
repetition format optimization...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-19 18:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 20:14 generic RDMA READ/WRITE API V7 Christoph Hellwig
2016-04-18 20:14 ` [PATCH 02/12] IB/cma: pass the port number to ib_create_qp Christoph Hellwig
2016-04-18 20:14 ` [PATCH 03/12] IB/core: allow passing mapping an offset into the SG in ib_map_mr_sg Christoph Hellwig
2016-04-18 20:14 ` [PATCH 04/12] IB/core: add a helper to check for READ WITH INVALIDATE support Christoph Hellwig
2016-04-18 20:14 ` [PATCH 05/12] IB/core: refactor ib_create_qp Christoph Hellwig
2016-04-18 20:14 ` [PATCH 06/12] IB/core: add a simple MR pool Christoph Hellwig
[not found] ` <1461010463-6603-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-18 20:14 ` [PATCH 01/12] IB/mlx5: Expose correct max_sge_rd limit Christoph Hellwig
2016-04-18 20:14 ` [PATCH 07/12] IB/core: add a need_inval flag to struct ib_mr Christoph Hellwig
2016-04-18 20:14 ` [PATCH 08/12] IB/core: generic RDMA READ/WRITE API Christoph Hellwig
2016-04-18 20:14 ` [PATCH 09/12] target: enhance and export target_alloc_sgl/target_free_sgl Christoph Hellwig
2016-04-19 14:11 ` Sagi Grimberg
2016-04-18 20:14 ` [PATCH 10/12] IB/srpt: convert to the generic RDMA READ/WRITE API Christoph Hellwig
2016-04-18 20:14 ` [PATCH 11/12] IB/core: add RW API support for signature MRs Christoph Hellwig
[not found] ` <1461010463-6603-12-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-19 14:20 ` Sagi Grimberg
2016-04-19 17:26 ` Jason Gunthorpe
[not found] ` <20160419172627.GC20844-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-04-19 18:29 ` Christoph Hellwig
[not found] ` <20160419182950.GC989-jcswGhMUV9g@public.gmane.org>
2016-04-19 18:46 ` Sagi Grimberg [this message]
[not found] ` <57163E99.8090301-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-19 18:27 ` Christoph Hellwig
2016-04-18 20:14 ` [PATCH 12/12] IB/isert: convert to the generic RDMA READ/WRITE API Christoph Hellwig
2016-04-19 14:23 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2016-04-11 21:32 generic RDMA READ/WRITE API V6 Christoph Hellwig
2016-04-11 21:32 ` [PATCH 11/12] IB/core: add RW API support for signature MRs Christoph Hellwig
[not found] ` <1460410360-13104-12-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-22 21:53 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57167CF0.5090405@grimberg.me \
--to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
--cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).