From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 11/11] IB/srp: Prevent mapping failures Date: Sun, 24 Apr 2016 17:48:53 -0700 Message-ID: <571D6975.2020905@sandisk.com> References: <571A936F.7040409@sandisk.com> <571A94AF.7000609@sandisk.com> <20160424083538.GF7974@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160424083538.GF7974-2ukJVAZIZ/Y@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: Doug Ledford , Christoph Hellwig , Sagi Grimberg , Laurence Oberman , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 04/24/16 01:35, Leon Romanovsky wrote: > On Fri, Apr 22, 2016 at 02:16:31PM -0700, Bart Van Assche wrote: >> + max_max_sectors = (srp_dev->max_pages_per_mr - 1) << >> + (ilog2(srp_dev->mr_page_size) - 9); > > From my understanding, srp_dev->max_pages_per_mr can be equal to 1, in > case device will advertise it. > > Is this understanding correct? > Will the code work in such case? Hello Leon, I'm not sure a HCA driver exists for which max_pages_per_mr == 1. Additionally, I'm not sure such a driver would be useful because such a driver would limit the maximum data transfer size for the iSER protocol to 4 KB. That is too low to reach good performance. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html