From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Bart Van Assche
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH] IB/core: Don't drain the receive queue for srq attached queue-pair
Date: Tue, 26 Apr 2016 22:11:07 +0300 [thread overview]
Message-ID: <571FBD4B.2030102@grimberg.me> (raw)
In-Reply-To: <571F8D48.4020503-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
>> SRQ attached QPs will fail receive work posts does not
>> have a receive queue that needs to be drained, the receive
>> queue is shared.
>
> The patch itself looks fine to me but the description of this patch is
> very confusing.
Sorry for the poor change log :) I was in a hurry (just now got back)
and quickly wrote description and sent out the patch without giving the
phrasing any thought.
> How about explaining that either an SRQ or an RQ is
> attached to a QP and hence that if an SRQ has been attached that there
> is no RQ attached and hence that it should not be drained?
I'll send out a better description, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-26 19:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 14:55 [PATCH] IB/core: Don't drain the receive queue for srq attached queue-pair Sagi Grimberg
[not found] ` <1461682538-19647-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-26 15:07 ` Steve Wise
[not found] ` <CAB5WxwfAGL2qCe7w6A=mKQ65mwjbKKbp_8qFJFRF6Aj7tE+tLQ@mail.gmail.com>
[not found] ` <CAB5WxwfAGL2qCe7w6A=mKQ65mwjbKKbp_8qFJFRF6Aj7tE+tLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-26 15:43 ` Christoph Hellwig
[not found] ` <20160426154328.GA12398-jcswGhMUV9g@public.gmane.org>
2016-04-26 15:55 ` Chuck Lever
[not found] ` <912C9E71-05E3-4ED9-9B41-137E131E3A71-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-04-26 16:00 ` Steve Wise
[not found] ` <571F9084.2040506-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2016-04-26 16:04 ` Bart Van Assche
[not found] ` <571F917C.40008-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-04-26 16:28 ` Steve Wise
[not found] ` <571F972B.6030904-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2016-04-26 17:27 ` Bart Van Assche
[not found] ` <571FA4E5.2030501-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-04-26 17:35 ` Steve Wise
[not found] ` <571FA6D5.2060607-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2016-04-26 19:24 ` Sagi Grimberg
[not found] ` <571FC051.7020009-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-26 19:25 ` Steve Wise
2016-04-26 19:20 ` Sagi Grimberg
2016-04-26 19:18 ` Sagi Grimberg
2016-04-26 19:18 ` Sagi Grimberg
2016-04-26 19:15 ` Sagi Grimberg
2016-04-26 19:07 ` Sagi Grimberg
2016-04-26 15:46 ` Bart Van Assche
[not found] ` <571F8D48.4020503-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-04-26 19:11 ` Sagi Grimberg [this message]
[not found] ` <571FBD4B.2030102-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-26 20:06 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571FBD4B.2030102@grimberg.me \
--to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).