Re: [PATCH] IB/core: Don't drain the receive queue for srq attached queue-pair

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 887 bytes --]

On 4/26/2016 3:11 PM, Sagi Grimberg wrote:
> 
>>> SRQ attached QPs will fail receive work posts does not
>>> have a receive queue that needs to be drained, the receive
>>> queue is shared.
>>
>> The patch itself looks fine to me but the description of this patch is
>> very confusing.
> 
> Sorry for the poor change log :) I was in a hurry (just now got back)
> and quickly wrote description and sent out the patch without giving the
> phrasing any thought.
> 
>> How about explaining that either an SRQ or an RQ is
>> attached to a QP and hence that if an SRQ has been attached that there
>> is no RQ attached and hence that it should not be drained?
> 
> I'll send out a better description, thanks.

I already picked the patch up and reworded the description myself.  See
if you are happy with it.  If not, I'll reword it again before sending a
pull request.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]