Re: [PATCH v2 15/18] xprtrdma: Refactor __fmr_dma_unmap()

[Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>]

> diff --git a/net/sunrpc/xprtrdma/fmr_ops.c b/net/sunrpc/xprtrdma/fmr_ops.c
> index 009694b..9d50f3a 100644
> --- a/net/sunrpc/xprtrdma/fmr_ops.c
> +++ b/net/sunrpc/xprtrdma/fmr_ops.c
> @@ -186,15 +186,10 @@ static void
>   __fmr_dma_unmap(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg)
>   {
>   	struct ib_device *device = r_xprt->rx_ia.ri_device;
> -	struct rpcrdma_mw *mw = seg->rl_mw;
>   	int nsegs = seg->mr_nsegs;
>
> -	seg->rl_mw = NULL;
> -
>   	while (nsegs--)
>   		rpcrdma_unmap_one(device, seg++);

When will we get to see this in the form of dma_unmap_sg()? ;)

Looks fine anyways...

Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html