From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v2 13/18] xprtrdma: Refactor the FRWR recovery worker Date: Tue, 26 Apr 2016 23:33:37 +0300 Message-ID: <571FD0A1.90501@grimberg.me> References: <20160425185956.3566.64142.stgit@manet.1015granger.net> <20160425192234.3566.63698.stgit@manet.1015granger.net> <571FCC8C.5040503@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chuck Lever Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux NFS Mailing List List-Id: linux-rdma@vger.kernel.org On 26/04/16 23:30, Chuck Lever wrote: > >> On Apr 26, 2016, at 4:16 PM, Sagi Grimberg wrote: >> >> >>> +static void >>> +__frwr_reset_and_unmap(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mw *mw) >>> +{ >>> + struct rpcrdma_ia *ia = &r_xprt->rx_ia; >>> + struct rpcrdma_frmr *f = &mw->frmr; >>> + int rc; >>> + >>> + rc = __frwr_reset_mr(ia, mw); >>> + ib_dma_unmap_sg(ia->ri_device, f->fr_sg, f->fr_nents, f->fr_dir); >>> + if (rc) >>> + return; >>> + >>> + rpcrdma_put_mw(r_xprt, mw); >>> +} >>> + >> >> If this is not being called from other sites I'd say just >> do it in __frwr_recovery_worker instead of having it just bouncing >> the call... > > It will be called from another site in 16/18. I see, alright then, Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html