From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wei Hu (Xavier)" Subject: Re: [PATCH -next] IB/hns: Fix return value check in hns_roce_get_cfg() Date: Thu, 11 Aug 2016 18:43:32 +0800 Message-ID: <57AC56D4.3050401@huawei.com> References: <1470445284-28970-1-git-send-email-weiyj.lk@gmail.com> <20160807053115.GQ27667@leon.nu> <087f4381-d830-fc57-ea5d-c516a1b160b5@gmail.com> <20160807131419.GS27667@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160807131419.GS27667-2ukJVAZIZ/Y@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: Leon Romanovsky , Wei Yongjun , Lijun Ou , Sean Hefty , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Hi, Doug Ledford Can you give me a suggestion that what we should do? Thanks very much! Regards Wei Hu On 2016/8/7 21:14, Leon Romanovsky wrote: > On Sun, Aug 07, 2016 at 08:19:39PM +0800, Wei Yongjun wrote: >> On 08/07/2016 01:31 PM, Leon Romanovsky wrote: >>> On Sat, Aug 06, 2016 at 01:01:24AM +0000, Wei Yongjun wrote: >>>> In case of error, the function devm_ioremap_resource() returns ERR_PTR() >>>> and never returns NULL. The NULL test in the return value check should >>>> be replaced with IS_ERR(). >>>> >>>> Signed-off-by: Wei Yongjun >>> On which branch did you base your patch? >>> It would be helpful to us if you followed SubmittionPatches document, >>> section with Fixes description. In such case "git describe" will give >>> immediate answer on my first question. >>> >> This patch is based on the linux-next.git tree. >> Fixes: 5e43122add63 ('IB/hns: Add driver files for hns RoCE driver') > This driver wasn't part of last pull request and it is worth to consult > with Doug Ledford on the plans for this driver (stay in ->next, resubmit > e.t.c). > > Right now, there is no tree to apply this patch. > > Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html