Re: [PATCH -next] IB/hns: Fix return value check in hns_roce_get_cfg()

Wei Yongjun
2016-08-07T12:19:39Z

On 08/07/2016 01:31 PM, Leon Romanovsky wrote:
> On Sat, Aug 06, 2016 at 01:01:24AM +0000, Wei Yongjun wrote:
>> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
>> and never returns NULL. The NULL test in the return value check should
>> be replaced with IS_ERR().
>>
>> Signed-off-by: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> On which branch did you base your patch?
> It would be helpful to us if you followed SubmittionPatches document,
> section with Fixes description. In such case "git describe" will give
> immediate answer on my first question.
>
This patch is based on the linux-next.git tree.
Fixes: 5e43122add63 ('IB/hns: Add driver files for hns RoCE driver')