Re: [PATCH -next] IB/hns: Fix return value check in hns_roce_get_cfg()

Leon Romanovsky
2016-08-07T13:14:19Z

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On Sun, Aug 07, 2016 at 08:19:39PM +0800, Wei Yongjun wrote:
> On 08/07/2016 01:31 PM, Leon Romanovsky wrote:
> > On Sat, Aug 06, 2016 at 01:01:24AM +0000, Wei Yongjun wrote:
> >> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> >> and never returns NULL. The NULL test in the return value check should
> >> be replaced with IS_ERR().
> >>
> >> Signed-off-by: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > On which branch did you base your patch?
> > It would be helpful to us if you followed SubmittionPatches document,
> > section with Fixes description. In such case "git describe" will give
> > immediate answer on my first question.
> >
> This patch is based on the linux-next.git tree.
> Fixes: 5e43122add63 ('IB/hns: Add driver files for hns RoCE driver')

This driver wasn't part of last pull request and it is worth to consult
with Doug Ledford on the plans for this driver (stay in ->next, resubmit
e.t.c).

Right now, there is no tree to apply this patch.

Thanks
>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]