Re: [PATCH -next] IB/hns: Fix return value check in hns_roce_get_cfg()

Wei Hu (Xavier)
2016-08-23T01:56:53Z

On 2016/8/23 2:15, Doug Ledford wrote:
> On 8/11/2016 6:43 AM, Wei Hu (Xavier) wrote:
>> Hi, Doug Ledford
>>
>> Can you give me a suggestion that what we should do? Thanks very much!
> I still have a branch for your driver, the hns-roce branch in my tree
> (only available via my github repo for now). Now that Dave Miller has
> taken in the most recent patch to add the needed reset function to the
> hns net driver, I rebased your branch in my tree on his net-next branch.
> I'll submit it in the next merge window. I then applied this patch on
> top of that branch. So, future patches to your driver need to be
> against my hns-roce branch in my github repo, at least until I merge it
> into my official k.o/for-4.9 branch.
Hi, Doug Ledford
Can you provide us your hns-roce branch in github repo?
Many thanks
Wei Hu
>> Regards
>> Wei Hu
>>
>> On 2016/8/7 21:14, Leon Romanovsky wrote:
>>> On Sun, Aug 07, 2016 at 08:19:39PM +0800, Wei Yongjun wrote:
>>>> On 08/07/2016 01:31 PM, Leon Romanovsky wrote:
>>>>> On Sat, Aug 06, 2016 at 01:01:24AM +0000, Wei Yongjun wrote:
>>>>>> In case of error, the function devm_ioremap_resource() returns
>>>>>> ERR_PTR()
>>>>>> and never returns NULL. The NULL test in the return value check should
>>>>>> be replaced with IS_ERR().
>>>>>>
>>>>>> Signed-off-by: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>>> On which branch did you base your patch?
>>>>> It would be helpful to us if you followed SubmittionPatches document,
>>>>> section with Fixes description. In such case "git describe" will give
>>>>> immediate answer on my first question.
>>>>>
>>>> This patch is based on the linux-next.git tree.
>>>> Fixes: 5e43122add63 ('IB/hns: Add driver files for hns RoCE driver')
>>> This driver wasn't part of last pull request and it is worth to consult
>>> with Doug Ledford on the plans for this driver (stay in ->next, resubmit
>>> e.t.c).
>>>
>>> Right now, there is no tree to apply this patch.
>>>
>>> Thanks
>>