Re: [PATCH V1 rdma-core 0/5] Licensing and cleanup issues

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 4162 bytes --]

On 9/29/16 7:10 AM, Yishai Hadas wrote:
> Sending V1 to introduce few notes got from Jason, details below.
> 
> This series comes to solve some potential licensing issue around list.h
> and ocrdma_list.h by using the CCAN functionality which has BSD license.
> 
> The CCAN required functionality was taken as is with minor touches as of
> flattening the directory structure, its original header
> with the licensing note was preserved.
> 
> In addition, the series drops some local definitions and use shared code instead.
> Pull request was sent [1]
> 
> [1] https://github.com/linux-rdma/rdma-core/pull/5
> 
> Changes from V0:
> Patch #2: Move to use min_t/max_t and fix typing issues among the project.
>           Add involved license files to ccan.
> 	  Sort list of files in ccan/CMakeLists.txt.
> 	  Use buildlib/config.h.in for ccan HAVE_XXX.

It looks to me as you successfully addressed Jason's comments, so I've
merged this patch set.  Future changes will need to be incremental
patches.  Thanks!


> Patch #3: Add ccan/str.c and update relevant cmake files.
>           Sort list of files in ccan/CMakeLists.txt. 
> 
> Yishai Hadas (5):
>   Remove container_of and offset local declarations
>   ccan: Add CCAN min and max functionality
>   ccan: Add list functionality
>   libmlx5: Move to use CCAN list functionality
>   libocrdma: Move to use CCAN list functionality
> 
>  CMakeLists.txt                       |   1 +
>  buildlib/config.h.in                 |  10 +
>  buildlib/publish_headers.cmake       |  18 +-
>  buildlib/rdma_functions.cmake        |   8 +
>  ccan/BSD-MIT                         |  17 +
>  ccan/CC0                             |  97 ++++
>  ccan/CMakeLists.txt                  |  16 +
>  ccan/build_assert.h                  |  40 ++
>  ccan/check_type.h                    |  64 +++
>  ccan/container_of.h                  | 146 ++++++
>  ccan/list.h                          | 842 +++++++++++++++++++++++++++++++++++
>  ccan/minmax.h                        |  65 +++
>  ccan/str.c                           |  13 +
>  ccan/str.h                           | 228 ++++++++++
>  ccan/str_debug.h                     |  30 ++
>  ibacm/CMakeLists.txt                 |   6 +-
>  ibacm/linux/osd.h                    |   8 +-
>  ibacm/prov/acmp/src/acmp.c           |   2 +-
>  iwpmd/src/CMakeLists.txt             |   2 +-
>  libibcm/examples/CMakeLists.txt      |   2 +-
>  libibcm/src/cm.c                     |   5 -
>  libibumad/tests/CMakeLists.txt       |   4 +-
>  libibverbs/examples/CMakeLists.txt   |  16 +-
>  libibverbs/examples/rc_pingpong.c    |  12 +-
>  libmlx5/src/buf.c                    |  11 +-
>  libmlx5/src/list.h                   | 331 --------------
>  libmlx5/src/mlx5.c                   |   2 +-
>  libmlx5/src/mlx5.h                   |  19 +-
>  libmlx5/src/qp.c                     |   4 +-
>  libmlx5/src/srq.c                    |   2 +-
>  libmlx5/src/verbs.c                  |  21 +-
>  libocrdma/src/ocrdma_list.h          | 104 -----
>  libocrdma/src/ocrdma_main.c          |  24 +-
>  libocrdma/src/ocrdma_main.h          |  12 +-
>  libocrdma/src/ocrdma_verbs.c         |  33 +-
>  librdmacm/examples/CMakeLists.txt    |  26 +-
>  librdmacm/src/cma.h                  |  11 +-
>  librdmacm/src/rsocket.c              |  13 +-
>  srp_daemon/srp_daemon/CMakeLists.txt |   2 +-
>  39 files changed, 1692 insertions(+), 575 deletions(-)
>  create mode 100644 ccan/BSD-MIT
>  create mode 100644 ccan/CC0
>  create mode 100644 ccan/CMakeLists.txt
>  create mode 100644 ccan/build_assert.h
>  create mode 100644 ccan/check_type.h
>  create mode 100644 ccan/container_of.h
>  create mode 100644 ccan/list.h
>  create mode 100644 ccan/minmax.h
>  create mode 100644 ccan/str.c
>  create mode 100644 ccan/str.h
>  create mode 100644 ccan/str_debug.h
>  delete mode 100644 libmlx5/src/list.h
>  delete mode 100644 libocrdma/src/ocrdma_list.h
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>    GPG Key ID: 0E572FDD
  Red Hat, Inc.
  100 E. Davie St
  Raleigh, NC 27601 USA


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 907 bytes --]