From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Ficet Subject: Re: [PATCH infiniband-diags] Add Bull device ID support to device white lists Date: Fri, 9 Dec 2016 15:29:58 +0100 Message-ID: <584ABFE6.4070902@atos.net> References: <20161207145338.GD24724@phlsvsds.ph.intel.com> <584A8823.4070506@atos.net> <703b953b-7165-72d1-3c1e-c3b1f8c54f28@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <703b953b-7165-72d1-3c1e-c3b1f8c54f28-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hal Rosenstock , "ira.weiny" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org Hello, On 12/09/2016 03:15 PM, Hal Rosenstock wrote: > On 12/9/2016 5:32 AM, Vincent Ficet wrote: >> Hello, >> >> The patch proposed by Hal Rosenstock does not list all Bull device IDs. >> >> Please apply the attached patch which contains an up to date list of such IDs. > Would it be better to combine Bull Switch-IB and Switch-IB2 ranges into > one check rather than keeping them separate as the device IDs are > contiguous ? I just wanted to separate SwitchIB and SwitchIB2 for clarity, but we can gather them if you wish to do so. Which option do you prefer, together or split ? > > Also, looks like similar change should also be done in > ibdiag_common.c:is_mlnx_ext_port_info_supported. Thanks for pointing this. I'll fix it too, but first I need you to answer the question just above. Best Regards, Vincent > > -- Hal > >> Best Regards, >> >> Vincent -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html