Re: [PATCH infiniband-diags] Add Bull device ID support to device white lists

Vincent Ficet
2016-12-09T14:29:58Z

Hello,

On 12/09/2016 03:15 PM, Hal Rosenstock wrote:
> On 12/9/2016 5:32 AM, Vincent Ficet wrote:
>> Hello,
>>
>> The patch proposed by Hal Rosenstock does not list all Bull device IDs.
>>
>> Please apply the attached patch which contains an up to date list of such IDs.
> Would it be better to combine Bull Switch-IB and Switch-IB2 ranges into
> one check rather than keeping them separate as the device IDs are
> contiguous ?
I just wanted to separate SwitchIB and SwitchIB2 for clarity, but we can gather them if you wish to do so.

Which option do you prefer, together or split ?
>
> Also, looks like similar change should also be done in
> ibdiag_common.c:is_mlnx_ext_port_info_supported.
Thanks for pointing this. I'll fix it too, but first I need you to answer the question just above.

Best Regards,

Vincent
>
> -- Hal
>
>> Best Regards,
>>
>> Vincent