From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D01128E5E7
	for <linux-rdma@vger.kernel.org>; Tue, 13 May 2025 13:32:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1747143128; cv=none; b=kOyN7CsX7fb2MuQyFeTY56Ts5jnjAuzARisclsvXUnJCH6Gkqy2kPEQPYFGjsCscy+3DlZbEcaLgTlWu89uh3LQg/pxO06bCLZphkJwnwQaUvINgRs1dEzJZGx+AYyOuqSZzqN3XQqjb/Uvy3w12/+KXjCYd5E0GLWG9vjRXmQ4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1747143128; c=relaxed/simple;
	bh=z2haIjDqNrb4s1Ft9q/VKPrJ20SNCg8ofCGnU1k9Lx4=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=GfAwV+cyyW+aCC0odhOBjhYOqcsVwJmtY5RkcDa50ymd7HUBNbNbyAnnGtLXOtFa04Ef3Ao4sDriMnA42AWMxcWwUdjoULdcfn4aO+YF3fZ3+5qJ5g7gwHZAWG8sTOwLndIyO98avCkHWGMXbSF1808CvfxSh8UhgxydD9xoC68=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xGDTNX0z; arc=none smtp.client-ip=91.218.175.180
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xGDTNX0z"
Message-ID: <58e21463-6db8-4e26-b212-590453b1ddbf@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1747143120;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cNQdCCb9ecdF4xZ/wYPQwhqLJYrt76SqeLQABihcuco=;
	b=xGDTNX0zEv/pkFboH2sxbJy9Q80jSSlkWjLPbV/qzlBrA8dX+b+bIMWIRN08ks0Xmi4Qxd
	b59Tctqr7VnnFottq9Hyi975AZGVaTx0z1q4A7Gzedd2rxBf7mZED6WVOeLBZ+TnD9B3CK
	Axb+0J1sBs6KOJLkjPu4kfBV2oJgLOc=
Date: Tue, 13 May 2025 16:31:33 +0300
Precedence: bulk
X-Mailing-List: linux-rdma@vger.kernel.org
List-Id: <linux-rdma.vger.kernel.org>
List-Subscribe: <mailto:linux-rdma+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-rdma+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Subject: Re: [PATCH] driver/infiniband/efa: Fix possible null pointer
 dereference in `efa_alloc_pd()`
To: Thomas Fourier <fourier.thomas@gmail.com>
Cc: Michael Margolin <mrgolin@amazon.com>, Yossi Leybovich
 <sleybo@amazon.com>, Jason Gunthorpe <jgg@ziepe.ca>,
 Leon Romanovsky <leon@kernel.org>, Shiraz Saleem <shiraz.saleem@intel.com>,
 Steve Wise <larrystevenwise@gmail.com>, linux-rdma@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20250513132252.980614-1-fourier.thomas@gmail.com>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Gal Pressman <gal.pressman@linux.dev>
Content-Language: en-US
In-Reply-To: <20250513132252.980614-1-fourier.thomas@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT

On 13/05/2025 16:22, Thomas Fourier wrote:
> `efa_alloc_pd()` assumes that `udata` is not null but it seems like
> `__ib_alloc_pd()` in drivers/infiniband/core/verbs.c:279 can call it
> through the `ib_device` interface.  This checks if `udata` is null
> before dereferencing it.
> 
> Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>

udata will never be NULL since EFA does not support kverbs, and
userspace will always pass udata.

Look at ib_device_check_mandatory().