* [PATCH] RDS: null pointer dereference in rds_atomic_free_op
@ 2018-01-03 21:06 simo.ghannam
[not found] ` <5a4d45ce.8b8a1c0a.1d072.e5e1-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2018-01-04 19:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: simo.ghannam @ 2018-01-03 21:06 UTC (permalink / raw)
To: netdev, linux-rdma, santosh.shilimkar, davem, rds-devel; +Cc: Mohamed Ghannam
From: Mohamed Ghannam <simo.ghannam@gmail.com>
set rm->atomic.op_active to 0 when rds_pin_pages() fails
or the user supplied address is invalid,
this prevents a NULL pointer usage in rds_atomic_free_op()
Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com>
---
net/rds/rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index bc2f1e0977d6..398932fbaf27 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -874,6 +874,7 @@ int rds_cmsg_atomic(struct rds_sock *rs, struct rds_message *rm,
err:
if (page)
put_page(page);
+ rm->atomic.op_active = 0;
kfree(rm->atomic.op_notifier);
return ret;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <5a4d45ce.8b8a1c0a.1d072.e5e1-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>]
* Re: [PATCH] RDS: null pointer dereference in rds_atomic_free_op
[not found] ` <5a4d45ce.8b8a1c0a.1d072.e5e1-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
@ 2018-01-03 21:19 ` Santosh Shilimkar
0 siblings, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2018-01-03 21:19 UTC (permalink / raw)
To: simo.ghannam-Re5JQEeQqe8AvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
davem-fT/PcQaiUtIeIZ0/mPfg9Q, rds-devel-N0ozoZBvEnrZJqsBc5GL+g
On 1/3/2018 1:06 PM, simo.ghannam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Mohamed Ghannam <simo.ghannam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> set rm->atomic.op_active to 0 when rds_pin_pages() fails
> or the user supplied address is invalid,
> this prevents a NULL pointer usage in rds_atomic_free_op()
>
> Signed-off-by: Mohamed Ghannam <simo.ghannam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
Good catch !!
Acked-by: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDS: null pointer dereference in rds_atomic_free_op
2018-01-03 21:06 [PATCH] RDS: null pointer dereference in rds_atomic_free_op simo.ghannam
[not found] ` <5a4d45ce.8b8a1c0a.1d072.e5e1-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
@ 2018-01-04 19:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-04 19:20 UTC (permalink / raw)
To: simo.ghannam; +Cc: netdev, linux-rdma, santosh.shilimkar, rds-devel
From: simo.ghannam@gmail.com
Date: Wed, 3 Jan 2018 21:06:06 +0000
> From: Mohamed Ghannam <simo.ghannam@gmail.com>
>
> set rm->atomic.op_active to 0 when rds_pin_pages() fails
> or the user supplied address is invalid,
> this prevents a NULL pointer usage in rds_atomic_free_op()
>
> Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-04 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-03 21:06 [PATCH] RDS: null pointer dereference in rds_atomic_free_op simo.ghannam
[not found] ` <5a4d45ce.8b8a1c0a.1d072.e5e1-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2018-01-03 21:19 ` Santosh Shilimkar
2018-01-04 19:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox