From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C89B16FF41; Mon, 1 Jul 2024 20:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719864863; cv=none; b=h+4CaH+A8JcPRitrE2mCQEsZVtppFgIHpzOYpQICSvvOUmmKLPYAMPlICc1uHkAWtfgnGexztZlJ9pWmVqAqZvqfhc+ZosO577GR54GdRUH4uwIhuyA6GRBfa8xJ3LAR466TrHQywA8yad/cXJKlBwjiXk3Fx9thLzFgGoqdZrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719864863; c=relaxed/simple; bh=on5WVIclPkUFu3F4jhc3/dJr8reOuiDULJmhQJbCJfU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q1FXs60AaOkUjNTQ7m7p/bUJ6vNVKQk72Em5gz/okacmVxyzDfndLDVSe6hdQzoQdantxLomWBRdy6Kvr0j1tplqN4+izhi0vdEXg1Rksp/SrccnK97GCHul7VRkwVgF5yMQcwdV0NKrzhZBLXfDoRATI5yxpR0Kp2hyoAYVOZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZwiD7hJD; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZwiD7hJD" X-Envelope-To: kotaranov@linux.microsoft.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719864858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vVcX2CswbR9UqeUv5mjFgUSyxPx+TGqXWoaQOVEf264=; b=ZwiD7hJDDV5UzHgeRrn00a0K1XK2mTwKIT1fHzo+/wiAzSLfdnW/U6K+Gy+1fHY5Rs+sPo To16EGr9/2xhpZu8IQQaMbgfo0zqyYqY6SHvYCumLHP1pVSewM0qy1CmvdoS26iktQe6+t t2v+anKsIlQ13kRomxH1cPc9H/xnOJo= X-Envelope-To: kotaranov@microsoft.com X-Envelope-To: pabeni@redhat.com X-Envelope-To: haiyangz@microsoft.com X-Envelope-To: kys@microsoft.com X-Envelope-To: edumazet@google.com X-Envelope-To: kuba@kernel.org X-Envelope-To: davem@davemloft.net X-Envelope-To: decui@microsoft.com X-Envelope-To: wei.liu@kernel.org X-Envelope-To: sharmaajay@microsoft.com X-Envelope-To: longli@microsoft.com X-Envelope-To: jgg@ziepe.ca X-Envelope-To: leon@kernel.org X-Envelope-To: linux-rdma@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: netdev@vger.kernel.org Message-ID: <5b418472-4370-4626-9373-064e7aaf9ae5@linux.dev> Date: Tue, 2 Jul 2024 04:14:07 +0800 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 1/2] net: mana: introduce helper to get a master netdev To: Konstantin Taranov , kotaranov@microsoft.com, pabeni@redhat.com, haiyangz@microsoft.com, kys@microsoft.com, edumazet@google.com, kuba@kernel.org, davem@davemloft.net, decui@microsoft.com, wei.liu@kernel.org, sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <1719838736-20338-1-git-send-email-kotaranov@linux.microsoft.com> <1719838736-20338-2-git-send-email-kotaranov@linux.microsoft.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <1719838736-20338-2-git-send-email-kotaranov@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2024/7/1 20:58, Konstantin Taranov 写道: > From: Konstantin Taranov > > Add helper to get a master netdevice for a given port. > When mana is used with netvsc, the VF netdev is controlled > by an upper netvsc device. In a baremetal case, the VF > netdev is the master device. > > Signed-off-by: Konstantin Taranov > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 18 ++++++++++++++++++ > include/net/mana/mana.h | 2 ++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index d087cf9..b893339 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -2948,3 +2948,21 @@ out: > gd->gdma_context = NULL; > kfree(ac); > } > + > +/* the caller should hold rcu_read_lock */ > +struct net_device *mana_get_master_netdev_rcu(struct mana_context *ac, u32 port_index) > +{ > + struct net_device *ndev; From the comments, this function requires rcu_read_lock. Can the following be added in this function? RCU_LOCKDEP_WARN(!rcu_read_lock_held(), "no rcu read lock held"); If rcu_read_lock is not held, this function will notify the caller. This can explicitly ensure that rcu_read_lock should be held before this fuction is called. Best Regards, Zhu Yanjun > + > + if (port_index >= ac->num_ports) > + return NULL; > + > + /* When mana is used in netvsc, the upper netdevice should be returned. */ > + if (ac->ports[port_index]->flags & IFF_SLAVE) > + ndev = netdev_master_upper_dev_get_rcu(ac->ports[port_index]); > + else > + ndev = ac->ports[port_index]; > + > + return ndev; > +} > +EXPORT_SYMBOL_NS(mana_get_master_netdev_rcu, NET_MANA); > diff --git a/include/net/mana/mana.h b/include/net/mana/mana.h > index 46f741e..2d3625c 100644 > --- a/include/net/mana/mana.h > +++ b/include/net/mana/mana.h > @@ -797,4 +797,6 @@ void mana_destroy_wq_obj(struct mana_port_context *apc, u32 wq_type, > int mana_cfg_vport(struct mana_port_context *apc, u32 protection_dom_id, > u32 doorbell_pg_id); > void mana_uncfg_vport(struct mana_port_context *apc); > + > +struct net_device *mana_get_master_netdev_rcu(struct mana_context *ac, u32 port_index); > #endif /* _MANA_H */