RE: [PATCH V4 for-next 02/10] IB/core: Introduce Work Queue object and its verbs

Steve Wise
2016-05-24T14:25:41Z

> > Hey Yishai,
> >
> > What happens to posted RQ WRs when transitioning from RDY->RESET,
> > RDY->ERR, and ERR->RESET?
> > Shouldn't the state machine be defined more?
>
> When the external RQ (i.e. WQ from type RQ) is moved to error/reset
> state it will behave similarly to the receive queue part of a QP when it
> enters error/reset state.
>
> Specifically,
> When moving to RESET:
> RQ attributes are reset to the same values after the RQ was created.
> Outstanding Work Requests are removed from the queues without notifying
> the Consumer.
>
> When Moving to ERR:
> RQ processing is stopped. Work Requests pending or in process are
> completed in error.
>

Thanks for the explanation. These semantics should be documented somewhere.

This series appears to me to be reasonable.

Series Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

Thanks,

Steve.