From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>, <linux-rdma@vger.kernel.org>,
<jgg@nvidia.com>
Subject: Re: [RFC PATCH] RDMA/rxe: Export imm_data to WC when the related WR with imm_data finished on SQ
Date: Fri, 29 Jan 2021 13:42:16 +0800 [thread overview]
Message-ID: <6013A038.9000903@cn.fujitsu.com> (raw)
In-Reply-To: <b4f0d73c-9624-b971-e56a-f1db02d683e3@gmail.com>
On 2021/1/28 3:40, Bob Pearson wrote:
> On 1/27/21 6:04 AM, Leon Romanovsky wrote:
>> On Wed, Jan 27, 2021 at 04:24:31PM +0800, Xiao Yang wrote:
>>> Even if we enable sq_sig_all or IBV_SEND_SIGNALED, current rxe
>>> module cannot set imm_data in WC when the related WR with imm_data
>>> finished on SQ.
>>>
>>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>>> ---
>>>
>>> Current rxe module and other rdma modules(e.g. mlx5) only set
>>> imm_data in WC when the related WR with imm_data finished on RQ.
>>> I am not sure if it is a expected behavior.
>> This is IBTA behavior.
>>
>> 5.2.11 IMMEDIATE DATA EXTENDED TRANSPORT HEADER (ImmDt) - 4 BYTES
>> "Immediate Data (ImmDt) contains data that is placed in the receive
>> Completion Queue Element (CQE). The ImmDt is only allowed in SEND or
>> RDMA WRITE packets with Immediate Data."
>>
>> If I understand the spec, you shouldn't set imm_data in SQ.
>>
>> Thanks
>>
> This seems a little confused to me. wc.imm_data is set in rxe_resp.c in response to an incoming request packet that contains an IMMDT extension header. I.e. a write with immediate or send with immediate opcode from the remote end of the wire. This wc is delivered to the receive completion queue when the message is complete. It should not have anything to do with the local send work queue entries.
Hi Bob,
Current rdma modules(e.g softroce, mlx5) only set wc_flags to
IBV_WC_WITH_IMM for the completed send work queue entries.
I am not sure if it is also the IBTA behavior.
Best Regards,
Xiao Yang
> Bob Pearson
>
>
> .
>
next prev parent reply other threads:[~2021-01-29 5:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 8:24 [RFC PATCH] RDMA/rxe: Export imm_data to WC when the related WR with imm_data finished on SQ Xiao Yang
2021-01-27 12:04 ` Leon Romanovsky
2021-01-27 13:19 ` Zhu Yanjun
2021-01-27 19:40 ` Bob Pearson
2021-01-29 5:42 ` Xiao Yang [this message]
2021-01-29 5:49 ` Pearson, Robert B
2021-01-29 18:14 ` Pearson, Robert B
2021-01-28 2:25 ` Xiao Yang
2021-01-28 6:29 ` Xiao Yang
2021-01-28 12:54 ` Leon Romanovsky
2021-01-29 2:14 ` Xiao Yang
2021-01-29 5:41 ` Pearson, Robert B
2021-01-29 6:28 ` Zhu Yanjun
2021-02-03 5:23 ` Xiao Yang
2021-02-03 7:36 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6013A038.9000903@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox