* [PATCH] RDMA/rxe: Don't overwrite errno from ib_umem_get()
@ 2021-06-21 6:57 ice_yangxiao
2021-06-21 7:20 ` yangx.jy
0 siblings, 1 reply; 2+ messages in thread
From: ice_yangxiao @ 2021-06-21 6:57 UTC (permalink / raw)
To: linux-rdma; +Cc: leon, zyjzyj2000, Xiao Yang
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
rxe_mr_init_user() always returns the fixed -EINVAL when ib_umem_get()
fails so it's hard for user to know which actual error happens in
ib_umem_get(). For example, ib_umem_get() will return -EOPNOTSUPP
when trying to pin pages on a DAX file.
Return actual error as mlx4/mlx5 does.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 9f63947bab12..fe2b7d223183 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -135,7 +135,7 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
if (IS_ERR(umem)) {
pr_warn("err %d from rxe_umem_get\n",
(int)PTR_ERR(umem));
- err = -EINVAL;
+ err = PTR_ERR(umem);
goto err1;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] RDMA/rxe: Don't overwrite errno from ib_umem_get()
2021-06-21 6:57 [PATCH] RDMA/rxe: Don't overwrite errno from ib_umem_get() ice_yangxiao
@ 2021-06-21 7:20 ` yangx.jy
0 siblings, 0 replies; 2+ messages in thread
From: yangx.jy @ 2021-06-21 7:20 UTC (permalink / raw)
To: linux-rdma@vger.kernel.org
Cc: ice_yangxiao@163.com, leon@kernel.org, zyjzyj2000@gmail.com,
yangx.jy@fujitsu.com
On 2021/6/21 14:57, ice_yangxiao@163.com wrote:
> From: Xiao Yang <yangx.jy@cn.fujitsu.com>
Hi,
Sorry for the wrong mail address and I have resent the patch.
> rxe_mr_init_user() always returns the fixed -EINVAL when ib_umem_get()
> fails so it's hard for user to know which actual error happens in
> ib_umem_get(). For example, ib_umem_get() will return -EOPNOTSUPP
> when trying to pin pages on a DAX file.
>
> Return actual error as mlx4/mlx5 does.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 9f63947bab12..fe2b7d223183 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -135,7 +135,7 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
> if (IS_ERR(umem)) {
> pr_warn("err %d from rxe_umem_get\n",
> (int)PTR_ERR(umem));
> - err = -EINVAL;
> + err = PTR_ERR(umem);
> goto err1;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-21 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-21 6:57 [PATCH] RDMA/rxe: Don't overwrite errno from ib_umem_get() ice_yangxiao
2021-06-21 7:20 ` yangx.jy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox