From: Roi Dayan <roid@nvidia.com>
To: YueHaibing <yuehaibing@huawei.com>,
saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
kliteyn@nvidia.com, mbloch@nvidia.com, erezsh@mellanox.com,
valex@nvidia.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/mlx5: DR, Fix uninitialized var warning
Date: Thu, 10 Nov 2022 16:43:53 +0200 [thread overview]
Message-ID: <613ca9c7-399b-08ac-8333-907128511e80@nvidia.com> (raw)
In-Reply-To: <20221110134707.43740-1-yuehaibing@huawei.com>
On 10/11/2022 15:47, YueHaibing wrote:
> Smatch warns this:
>
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c:81
> mlx5dr_table_set_miss_action() error: uninitialized symbol 'ret'.
>
> Initializing ret with -EOPNOTSUPP and fix missing action case.
>
> Fixes: 7838e1725394 ("net/mlx5: DR, Expose steering table functionality")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: init ret to -EOPNOTSUPP
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c
> index eb81759244d5..7cc4cb7fa392 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_table.c
> @@ -46,7 +46,7 @@ static int dr_table_set_miss_action_nic(struct mlx5dr_domain *dmn,
> int mlx5dr_table_set_miss_action(struct mlx5dr_table *tbl,
> struct mlx5dr_action *action)
> {
> - int ret;
> + int ret = -EOPNOTSUPP;
>
> if (action && action->action_type != DR_ACTION_TYP_FT)
> return -EOPNOTSUPP;
> @@ -67,6 +67,9 @@ int mlx5dr_table_set_miss_action(struct mlx5dr_table *tbl,
> goto out;
> }
>
> + if (ret)
> + goto out;
> +
> /* Release old action */
> if (tbl->miss_action)
> refcount_dec(&tbl->miss_action->refcount);
thanks
Reviewed-by: Roi Dayan <roid@nvidia.com>
next prev parent reply other threads:[~2022-11-10 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:47 [PATCH v2] net/mlx5: DR, Fix uninitialized var warning YueHaibing
2022-11-10 14:43 ` Roi Dayan [this message]
2022-11-11 22:19 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613ca9c7-399b-08ac-8333-907128511e80@nvidia.com \
--to=roid@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=erezsh@mellanox.com \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=valex@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox