From: "yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"tom@talpey.com" <tom@talpey.com>,
"yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>,
"y-goto@fujitsu.com" <y-goto@fujitsu.com>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>
Subject: Re: [RFC PATCH v2 2/2] RDMA/rxe: Support RDMA Atomic Write operation
Date: Tue, 18 Jan 2022 08:04:42 +0000 [thread overview]
Message-ID: <61E67499.4010408@fujitsu.com> (raw)
In-Reply-To: <20220117131624.GB7906@nvidia.com>
On 2022/1/17 21:16, Jason Gunthorpe wrote:
> On Thu, Jan 13, 2022 at 11:03:50AM +0800, Xiao Yang wrote:
>> +static enum resp_states process_atomic_write(struct rxe_qp *qp,
>> + struct rxe_pkt_info *pkt)
>> +{
>> + struct rxe_mr *mr = qp->resp.mr;
>> +
>> + u64 *src = payload_addr(pkt);
>> +
>> + u64 *dst = iova_to_vaddr(mr, qp->resp.va + qp->resp.offset, sizeof(u64));
>> + if (!dst || (uintptr_t)dst& 7)
>> + return RESPST_ERR_MISALIGNED_ATOMIC;
> It looks to me like iova_to_vaddr is completely broken, where is the
> kmap on that flow?
Hi Jason,
I think rxe_mr_init_user() maps the user addr space to the kernel addr
space during memory region registration, the mapping records are saved
into mr->cur_map_set->map[x].
Why do you think iova_to_vaddr() is completely broken?
Best Regards,
Xiao Yang
> Jason
next prev parent reply other threads:[~2022-01-18 8:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 3:03 [RFC PATCH v2 0/2] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2022-01-13 3:03 ` [RFC PATCH v2 1/2] RDMA/rxe: Rename send_atomic_ack() and atomic member of struct resp_res Xiao Yang
2022-01-13 3:03 ` [RFC PATCH v2 2/2] RDMA/rxe: Support RDMA Atomic Write operation Xiao Yang
2022-01-17 13:16 ` Jason Gunthorpe
2022-01-18 8:01 ` yangx.jy
2022-01-18 12:35 ` Jason Gunthorpe
2022-01-19 1:54 ` lizhijian
2022-01-19 12:36 ` Jason Gunthorpe
2022-01-19 16:47 ` Ira Weiny
2022-01-20 12:07 ` Li, Zhijian
2022-01-21 12:58 ` Jason Gunthorpe
2022-01-21 16:06 ` Ira Weiny
2022-01-21 16:08 ` Ira Weiny
2022-01-24 3:47 ` lizhijian
2022-01-27 9:37 ` yangx.jy
2022-01-27 9:57 ` hch
2022-01-27 18:08 ` Ira Weiny
2022-01-28 6:16 ` hch
2022-01-28 19:15 ` Ira Weiny
2022-02-10 11:06 ` yangx.jy
2022-02-11 18:30 ` Ira Weiny
2022-01-18 8:02 ` yangx.jy
2022-01-18 8:04 ` yangx.jy [this message]
2022-01-18 9:03 ` yangx.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61E67499.4010408@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).