From: "yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>
To: "rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>
Cc: "leon@kernel.org" <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-core RESEND] providers/rxe: Replace '%' with '&' in check_qp_queue_full()
Date: Tue, 18 Jan 2022 08:37:10 +0000 [thread overview]
Message-ID: <61E67C34.5070009@fujitsu.com> (raw)
In-Reply-To: <20220111022404.2375531-1-yangx.jy@fujitsu.com>
On 2022/1/11 10:24, Xiao Yang wrote:
> The expression "cons == ((qp->cur_index + 1) % q->index_mask)" mistakenly
> assumes the queue is full when the number of entires is equal to "maximum - 1"
> (maximum is correct).
>
> For example:
> If cons and qp->cur_index are 0 and q->index_mask is 1, check_qp_queue_full()
> reports ENOSPC.wrote
Hi Bob,
I think the commit message also misled you.
The expression "cons == ((qp->cur_index + 1) % q->index_mask)" mistakenly
assumes the queue is full when we create an empty two-slots queue (i.e. cur_index = 0 and cons = 0)
Best Regards,
Xiao Yang
prev parent reply other threads:[~2022-01-18 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 2:24 [PATCH rdma-core RESEND] providers/rxe: Replace '%' with '&' in check_qp_queue_full() Xiao Yang
2022-01-11 4:12 ` Devesh Sharma
2022-01-11 9:10 ` yangx.jy
2022-01-11 10:21 ` Devesh Sharma
2022-01-11 6:11 ` Leon Romanovsky
2022-01-11 9:19 ` yangx.jy
2022-01-11 10:47 ` Leon Romanovsky
2022-01-12 3:39 ` yangx.jy
2022-01-18 8:37 ` yangx.jy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61E67C34.5070009@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).