From: "yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>
To: Yanjun Zhu <yanjun.zhu@linux.dev>
Cc: Haakon Bugge <haakon.bugge@oracle.com>,
Jason Gunthorpe <jgg@nvidia.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>,
OFED mailing list <linux-rdma@vger.kernel.org>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>
Subject: Re: [PATCH] RDMA/rxe: Check the last packet by RXE_END_MASK
Date: Thu, 20 Jan 2022 09:33:15 +0000 [thread overview]
Message-ID: <61E92C59.20200@fujitsu.com> (raw)
In-Reply-To: <4e1e7cf6-d41b-6926-68cf-e58ca79a4559@linux.dev>
On 2022/1/19 22:08, Yanjun Zhu wrote:
> "
>
> ...
>
> Since the responder may choose to coalesce acknowledges, a single
> response packet may in fact acknowledge
> several request messages. Thus, when it receives a new MSN, the
> requester begins evaluating WQEs on its send queue beginning with the
> oldest outstanding WQE and progressing forward.
>
> ...
>
> "
>
> In the above, several request messages come. From the SPEC, msn should
> increase based on the number of request messages.
Hi Yanjun，
Current logic shows that posting a WQE on SQ increases SSN (SSN++) and
processing a WQE on responder successfully increases MSN (MSN++).
I think current SoftRoce doesn't implement the rule you metioned.
To be honest, the rule is not clear for me. when and how many
acknowledges of several request messages can we coalesce?
>
> Can your commit handle the above case?
No.
Best Regards,
Xiao Yang
>
>
> Zhu Yanjun
next prev parent reply other threads:[~2022-01-20 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 3:44 [PATCH] RDMA/rxe: Check the last packet by RXE_END_MASK Xiao Yang
2022-01-06 0:40 ` Jason Gunthorpe
2022-01-06 19:55 ` Robert Pearson
2022-01-07 11:49 ` Yanjun Zhu
2022-01-10 5:17 ` yangx.jy
2022-01-11 14:42 ` Yanjun Zhu
2022-01-11 15:16 ` Haakon Bugge
2022-01-12 1:19 ` Yanjun Zhu
2022-01-12 3:58 ` yangx.jy
2022-01-15 3:38 ` Yanjun Zhu
2022-01-18 2:20 ` yangx.jy
2022-01-19 14:08 ` Yanjun Zhu
2022-01-20 9:33 ` yangx.jy [this message]
2022-01-21 13:18 ` Yanjun Zhu
2022-02-08 16:40 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61E92C59.20200@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=david.marchand@6wind.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).