From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: David Laight <David.Laight@ACULAB.COM>,
'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Subject: Re: [PATCH v1 1/1] IB/hfi1: Don't cast parameter in bit operations
Date: Thu, 24 Feb 2022 08:38:25 -0500 [thread overview]
Message-ID: <646319a0-4297-edcc-db82-e4f3670cc84c@cornelisnetworks.com> (raw)
In-Reply-To: <e39730af26cc4a4d944fa3205fa17b3c@AcuMS.aculab.com>
On 2/23/22 4:44 PM, David Laight wrote:
> From: Andy Shevchenko
>> Sent: 23 February 2022 18:54
>>
>> While in this particular case it would not be a (critical) issue,
>> the pattern itself is bad and error prone in case somebody blindly
>> copies to their code.
>
> It is horribly wrong on BE systems.
Note that this driver has in Kconfig: depends on X86_64.
However it's a good point about not wanting anyone to blindly copy.
-Denny
prev parent reply other threads:[~2022-02-24 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 18:53 [PATCH v1 1/1] IB/hfi1: Don't cast parameter in bit operations Andy Shevchenko
2022-02-23 21:44 ` David Laight
2022-02-23 22:30 ` 'Andy Shevchenko'
2022-02-23 22:50 ` David Laight
2022-02-24 1:00 ` 'Andy Shevchenko'
2022-02-24 13:44 ` Dennis Dalessandro
2022-02-24 13:38 ` Dennis Dalessandro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646319a0-4297-edcc-db82-e4f3670cc84c@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=David.Laight@ACULAB.COM \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox