From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287D7C433F5 for ; Sun, 8 May 2022 08:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231342AbiEHIrO (ORCPT ); Sun, 8 May 2022 04:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230516AbiEHIrO (ORCPT ); Sun, 8 May 2022 04:47:14 -0400 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2F786400 for ; Sun, 8 May 2022 01:43:23 -0700 (PDT) Message-ID: <64a45406-b1ea-d3d6-2e6d-843fb9d9e59a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1651999401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i9GuJcMH2zuy0sFElGMEXbD0bEM3iRQAbMrd1OA6V5g=; b=YaRwkCZwuRG+9AuDy+RyRCxNr3vWTeUlp11uMcWwCKT+UArL8oCWTiAeI8jeCB+8cSdN5A l97Xfj+LQGUyz9kzDrtWDiT4fyC8FfjpPhro8RJ+MkIhPb0/14B7PEG2QwyV6R2Kiq/+dO 4nRLi3LtKBNkFF3tFETx8IoRc9MTSEw= Date: Sun, 8 May 2022 16:43:14 +0800 MIME-Version: 1.0 Subject: Re: Apparent regression in blktests since 5.18-rc1+ X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanjun Zhu To: Jason Gunthorpe Cc: Bart Van Assche , Bob Pearson , Zhu Yanjun , "linux-rdma@vger.kernel.org" , Bernard Metzler References: <4b0153c7-a8e9-98de-26ae-d421434a116d@linux.dev> <20220507012952.GH49344@nvidia.com> <81571bbb-c5d2-9b68-765d-f004eb7ba6fd@linux.dev> In-Reply-To: <81571bbb-c5d2-9b68-765d-f004eb7ba6fd@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org 在 2022/5/7 9:55, Yanjun Zhu 写道: > > 在 2022/5/7 9:29, Jason Gunthorpe 写道: >> On Sat, May 07, 2022 at 08:29:31AM +0800, Yanjun Zhu wrote: >> >>>> If I try to run the SRP test 002 with the soft-RoCE driver, the >>>> following appears: >>>> >>>> [  749.901966] ================================ >>>> [  749.903638] WARNING: inconsistent lock state >>>> [  749.905376] 5.18.0-rc5-dbg+ #1 Not tainted >>>> [  749.907039] -------------------------------- >>>> [  749.908699] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. >>>> [  749.910646] ksoftirqd/5/40 [HC0[0]:SC1[1]:HE0:SE0] takes: >>>> [  749.912499] ffff88818244d350 (&xa->xa_lock#14){+.?.}-{2:2}, at: >>>> rxe_pool_get_index+0x73/0x170 [rdma_rxe] >>>> [  749.914691] {SOFTIRQ-ON-W} state was registered at: >>>> [  749.916648]   __lock_acquire+0x45b/0xce0 >>>> [  749.918599]   lock_acquire+0x18a/0x450 >>>> [  749.920480]   _raw_spin_lock+0x34/0x50 >>>> [  749.922580]   __rxe_add_to_pool+0xcc/0x140 [rdma_rxe] >>>> [  749.924583]   rxe_alloc_pd+0x2d/0x40 [rdma_rxe] >>>> [  749.926394]   __ib_alloc_pd+0xa3/0x270 [ib_core] >>>> [  749.928579]   ib_mad_port_open+0x44a/0x790 [ib_core] >>>> [  749.930640]   ib_mad_init_device+0x8e/0x110 [ib_core] >>>> [  749.932495]   add_client_context+0x26a/0x330 [ib_core] >>>> [  749.934302]   enable_device_and_get+0x169/0x2b0 [ib_core] >>>> [  749.936217]   ib_register_device+0x26f/0x330 [ib_core] >>>> [  749.938020]   rxe_register_device+0x1b4/0x1d0 [rdma_rxe] >>>> [  749.939794]   rxe_add+0x8c/0xc0 [rdma_rxe] >>>> [  749.941552]   rxe_net_add+0x5b/0x90 [rdma_rxe] >>>> [  749.943356]   rxe_newlink+0x71/0x80 [rdma_rxe] >>>> [  749.945182]   nldev_newlink+0x21e/0x370 [ib_core] >>>> [  749.946917]   rdma_nl_rcv_msg+0x200/0x410 [ib_core] >>>> [  749.948657]   rdma_nl_rcv+0x140/0x220 [ib_core] >>>> [  749.950373]   netlink_unicast+0x307/0x460 >>>> [  749.952063]   netlink_sendmsg+0x422/0x750 >>>> [  749.953672]   __sys_sendto+0x1c2/0x250 >>>> [  749.955281]   __x64_sys_sendto+0x7f/0x90 >>>> [  749.956849]   do_syscall_64+0x35/0x80 >>>> [  749.958353]   entry_SYSCALL_64_after_hwframe+0x44/0xae >>>> [  749.959942] irq event stamp: 1411849 >>>> [  749.961517] hardirqs last  enabled at (1411848): >>>> [] >>>> __local_bh_enable_ip+0x88/0xf0 >>>> [  749.963338] hardirqs last disabled at (1411849): >>>> [] >>>> _raw_spin_lock_irqsave+0x5d/0x60 >>>> [  749.965214] softirqs last  enabled at (1411838): >>>> [] >>>> __do_softirq+0x467/0x6e1 >>>> [  749.967027] softirqs last disabled at (1411843): >>>> [] >>>> run_ksoftirqd+0x37/0x60 >>> To this, Please use this patch series >>> news://nntp.lore.kernel.org:119/20220422194416.983549-1-yanjun.zhu@linux.dev >>> >> No, that is the wrong fix for this. This is mismatched lock modes with >> the lookup path in the BH, the fix is to consistently use BH locking >> with the xarray everwhere or to use RCU. I'm expecting to go with >> Bob's RCU patch. > > Bob's RCU patch causes some atomic problems. Not sure these problems > can be fixed properly. I delved into Bob's rcu patch series, in this https://patchwork.kernel.org/project/linux-rdma/patch/20220421014042.26985-9-rpearsonhpe@gmail.com/, Sometimes __rxe_cleanup is called between spin_lock_irq and spin_unlock_irq. With Bob's rcu patch, this will cause oop. Best Regards, Zhu Yanjun > > Zhu Yanjun > >> >> We still need a proper patch for the AH problem. >> >> Jason