From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11CC627B339 for ; Wed, 1 Oct 2025 09:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759310898; cv=none; b=f/R+WSyFSNJNxKeHsOlOfT02zP/bstkzXiHZyoZUDXK8htZ1+PwPBeQFwT3B4kLOv43CR8hC3htYkzk9Vz3vIXhyEf05T+AKasypJ0CklIbKW2QeDTca5vDrwAxRjawk1Ft4Vh7/+FwSjeQTcSsxcvHtXLzeyJjfh5KBQd2MbzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759310898; c=relaxed/simple; bh=u8Q/puU00m1+Ma30hn2PbTN/YeCwD3+SnWOZqn5KRRE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HZWG0LcSjWoJ/iHKbZLK4LTfPJXUiGsLXHQsRet7xlzjvdaG7S3i8tQjjwNisabKnu1DarHW5li8eyAmzN4+BlzJEXYQhBzPedWLOZLGfnDqQLLJuE2Pw/9KUR04We2cFXwPmgpIrf4QZv0fZ7JegvfKQVtXjbIOqhebRPKT5jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BHKMtLub; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BHKMtLub" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759310896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ybtVMUpvDW3U/F2Zx0MRGWKL6mjqpdZhKS9ovQqZCJg=; b=BHKMtLubZVnUb3kgB8l8GqsQOgsRsfJQJORgdf1eigTzkrvrcMBtWwXXK7JK45Gcw8Q6aR DLMdlexDdwY70oyFUA059g04mpYC6ew0fNiD55sKAkoeE0Gy1K+I4VXBrY3sVzbjTOJMQC i+NHFO2+xR92ZRiQRCz9b0OuIXQrQnk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-XjgkPlgqMHWI1UWeNKGNMA-1; Wed, 01 Oct 2025 05:28:15 -0400 X-MC-Unique: XjgkPlgqMHWI1UWeNKGNMA-1 X-Mimecast-MFC-AGG-ID: XjgkPlgqMHWI1UWeNKGNMA_1759310894 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3f384f10762so4313750f8f.3 for ; Wed, 01 Oct 2025 02:28:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759310894; x=1759915694; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ybtVMUpvDW3U/F2Zx0MRGWKL6mjqpdZhKS9ovQqZCJg=; b=oIgwl9IKkX/lPpKRZKw12lWazBjtj3jbnPTxect556Tv90eHqhxwU1bGSWx+Q+K4ru wmxR9HMBzQs2qysv/sP9QD3SoHy/1w6+GF+4NICyt/VL7R6yW+U4avdfyTLFYNR52yax 4JhF+Z7fI6pSxiioqW3kW4Jgoy5yIOuD+AYc8RB1kUnV0GYigLe/RA5dqRaxVRGwSFsC TYRCsXU3DJUTwGSdKDasud+vU8ycUF2Tf8G9HSAnJE/QcrD4Go3ynGGUFpBmj+GBHFzv POSQYXMTqQKzeTfwUjD1Eu+aoAPSc29wD8a1OvXihPLDHRoESqWJmF4dfQlL/yv4COkd O48w== X-Forwarded-Encrypted: i=1; AJvYcCU3/TfywGka4ErrOWt4U1BFsKGGn7NPsjiUhuyyO94G47c0JCvB4f3qDNBF8u1wP7JPBw4yDlJrE1M+@vger.kernel.org X-Gm-Message-State: AOJu0YweNazZxbCMVHTGHJrBgVagoJ58jRYgk2SOi/omNuLhfUOu5sZL T9bWcjm/eNPpmioVxjUKu4sqEn3mimSqEzLMM/r1w3QoewRyH7ksM5F8bDN/vZSiRoD9b8v8Foa aA1o022BIcazTzNwzO5VmraOZ28uzBt5B9NKFVwwlzGuUr+tj7okSDXh3elMrS8M= X-Gm-Gg: ASbGncs0OiNTXgVGeL5H1Z4HRE9haa5mKuUcndsz3Mz+yiO/oH7gayHwzpptSGU6urv 60RA3EgtlmmpkGCKTiT1xjJCzZu7AhODc8xICJrw14j4Uszw77KWpLGgoIaQTkEqoE0LCaLKRaF fWZjDI1gpMbDv+jWzY95lZxeoIHp68cPD8hio3cvUyOlrYiNPcg+4hDCWLZvZCRkxSUEjtC0RgP jziafI08D2ZLUh3FuL4b+eE+nxqaO/mwURrKCz8mMY5Xkk13RW+K13cT7ElyV0jy4q3V1E1hAW5 GfxDuP2U8rKGrzOJklFDmPSGo7giN7HI8EOdRG08nA/3/2jRGPN/WIZMq2GoB/jYKp/ip2XJg/c YWTCz19SccOgoXW6wfw== X-Received: by 2002:a5d:588a:0:b0:3ec:248f:f86a with SMTP id ffacd0b85a97d-425578183aamr2084078f8f.48.1759310893694; Wed, 01 Oct 2025 02:28:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2jGX49TGzAee2RWy6ApUBj/jwFn2OVqWsFJymuz8OiVF8ehgSB3/azRECWeXusX/4XaZBCg== X-Received: by 2002:a5d:588a:0:b0:3ec:248f:f86a with SMTP id ffacd0b85a97d-425578183aamr2084020f8f.48.1759310893212; Wed, 01 Oct 2025 02:28:13 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fac4a5e41sm28042341f8f.0.2025.10.01.02.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 02:28:12 -0700 (PDT) Message-ID: <651ee9fe-706e-4471-a71b-e7a12b42cc3e@redhat.com> Date: Wed, 1 Oct 2025 11:28:09 +0200 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next V6] net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs To: Tariq Toukan Cc: Saeed Mahameed , Leon Romanovsky , Mark Bloch , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman , Leon Romanovsky , Jason Gunthorpe , Michael Guralnik , Moshe Shemesh , Will Deacon , Alexander Gordeev , Andrew Morton , Christian Borntraeger , Borislav Petkov , Dave Hansen , Gerald Schaefer , Vasily Gorbik , Heiko Carstens , "H. Peter Anvin" , Justin Stitt , linux-s390@vger.kernel.org, llvm@lists.linux.dev, Ingo Molnar , Bill Wendling , Nathan Chancellor , Nick Desaulniers , Salil Mehta , Sven Schnelle , Thomas Gleixner , x86@kernel.org, Yisen Zhuang , Arnd Bergmann , Leon Romanovsky , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Michael Guralnik , patches@lists.linux.dev, Niklas Schnelle , Jijie Shao , Simon Horman , Patrisious Haddad , Andrew Lunn , Eric Dumazet , Catalin Marinas , Jakub Kicinski , "David S. Miller" References: <1759093688-841357-1-git-send-email-tariqt@nvidia.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <1759093688-841357-1-git-send-email-tariqt@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 9/28/25 11:08 PM, Tariq Toukan wrote: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c > index 999d6216648a..c281153bd411 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c > @@ -7,6 +7,10 @@ > #include "mlx5_core.h" > #include "wq.h" > > +#if IS_ENABLED(CONFIG_KERNEL_MODE_NEON) && IS_ENABLED(CONFIG_ARM64) > +#include > +#endif > + > #define TEST_WC_NUM_WQES 255 > #define TEST_WC_LOG_CQ_SZ (order_base_2(TEST_WC_NUM_WQES)) > #define TEST_WC_SQ_LOG_WQ_SZ TEST_WC_LOG_CQ_SZ > @@ -255,6 +259,27 @@ static void mlx5_wc_destroy_sq(struct mlx5_wc_sq *sq) > mlx5_wq_destroy(&sq->wq_ctrl); > } > > +static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16], > + size_t mmio_wqe_size, unsigned int offset) > +{ > +#if IS_ENABLED(CONFIG_KERNEL_MODE_NEON) && IS_ENABLED(CONFIG_ARM64) > + if (cpu_has_neon()) { > + kernel_neon_begin(); > + asm volatile > + (".arch_extension simd;\n\t" Here I'm observing build errors with aarch64-linux-gnu-gcc 12.1.1 20220507 (Red Hat Cross 12.1.1-1): /tmp/cchqHdeI.s: Assembler messages: /tmp/cchqHdeI.s:746: Error: unknown architectural extension `simd;' I can't reproduce the error on any recent compiler version via godbolt.org, so I *think* this should not block/be reverted for the MR, but could you please have a look soonish? Thanks, Paolo