Re: [PATCH rdma-next V3 6/6] RDMA/core: Unify style of IOCTL commands

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1289 bytes --]

On 9/7/2016 3:01 AM, Leon Romanovsky wrote:
> On Tue, Sep 06, 2016 at 01:00:12PM +0000, Dalessandro, Dennis wrote:
>> On Sun, 2016-09-04 at 14:30 +0300, Leon Romanovsky wrote:
>>> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>>
>>> MAD and HFI1 have different naming convention, this patch
>>> simplifies and unifies their defines and names.
>>>
>>> As part of cleanup, the HFI1 _NUM() macro and command indexes
>>> were removed. It has a potential to break applications which use
>>> these defines directly, while shouldn't.
>>
>> Please be explicit. It's not that it has potential. It *will* break
>> applications which use these defines directly.
> 
> Yes, you are right.
> 
> Doug,
> What do you expect from me? Respin?

No, I reworded the commit message myself:


    RDMA/core: Unify style of IOCTL commands

    MAD and HFI1 have different naming convention, this patch
    simplifies and unifies their defines and names.

    As part of cleanup, the HFI1 _NUM() macro and command indexes were
    removed (controversial). This will cause intentional (and arguably
    unnecessary) breakage to the PSM user space library.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]