RE: isert patch leaving resources behind

[Saravanan Vajravel <saravanan.vajravel@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

Ok. I will work on the resource leak issue on surprise removal and push
the patch. Until then, we can revert Commit: 699826f4e30a. I will find
some time this week to repro the resource leak issue.

Thanks & Regards,
Saravanan Vajravel
+91-80-46116256


-----Original Message-----
From: Leon Romanovsky <leon@kernel.org>
Sent: Sunday, August 20, 2023 11:04 PM
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>;
saravanan.vajravel@broadcom.com; OFED mailing list
<linux-rdma@vger.kernel.org>; Ehab Ababneh
<ehab.ababneh@cornelisnetworks.com>; Selvin Xavier
<selvin.xavier@broadcom.com>
Subject: Re: isert patch leaving resources behind

On Sun, Aug 20, 2023 at 05:46:12PM +0300, Sagi Grimberg wrote:
>
> > > > Commit: 699826f4e30a ("IB/isert: Fix incorrect release of isert
> > > > connection") is causing problems on OPA when we try to unload
> > > > the driver after doing iSCI testing. Reverting this commit causes
the problem to go away. Any ideas?
> > >
> > >
> > > Saravanan, can you please post kernel logs as you wrote "When a
> > > bunch of iSER target is cleared, this issue can lead to
> > > use-after-free memory issue as isert conn is twice released" in the
reverted commit?
> >
> > So what is the resolution here?
>
> We need saravanan to address the reported resource leak upon
> DEVICE_REMOVAL. If this stalls, I suggest we revert the offending
> commit and add it again without any leaks on surprise hca removals.

Thanks, I'll keep an eye on it, if we don't get patch by EOW, I will
revert it

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]