From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Jason Gunthorpe <jgg@nvidia.com>, Zhu Yanjun <yanjun.zhu@intel.com>
Cc: zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org,
syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 1/1] RDMA/rxe: Fix the use-before-initialization error of resp_pkts
Date: Sat, 10 Jun 2023 07:59:04 +0800 [thread overview]
Message-ID: <6b35e9a2-8ad5-cdc9-aef2-f1477ddda6eb@linux.dev> (raw)
In-Reply-To: <ZINbszg48aMRrbFP@nvidia.com>
在 2023/6/10 1:04, Jason Gunthorpe 写道:
> On Fri, Jun 02, 2023 at 11:54:08AM +0800, Zhu Yanjun wrote:
>> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>>
>> In the following:
>> "
>> Call Trace:
>> <TASK>
>> __dump_stack lib/dump_stack.c:88 [inline]
>> dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
>> assign_lock_key kernel/locking/lockdep.c:982 [inline]
>> register_lock_class+0xdb6/0x1120 kernel/locking/lockdep.c:1295
>> __lock_acquire+0x10a/0x5df0 kernel/locking/lockdep.c:4951
>> lock_acquire kernel/locking/lockdep.c:5691 [inline]
>> lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5656
>> __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
>> _raw_spin_lock_irqsave+0x3d/0x60 kernel/locking/spinlock.c:162
>> skb_dequeue+0x20/0x180 net/core/skbuff.c:3639
>> drain_resp_pkts drivers/infiniband/sw/rxe/rxe_comp.c:555 [inline]
>> rxe_completer+0x250d/0x3cc0 drivers/infiniband/sw/rxe/rxe_comp.c:652
>> rxe_qp_do_cleanup+0x1be/0x820 drivers/infiniband/sw/rxe/rxe_qp.c:761
>> execute_in_process_context+0x3b/0x150 kernel/workqueue.c:3473
>> __rxe_cleanup+0x21e/0x370 drivers/infiniband/sw/rxe/rxe_pool.c:233
>> rxe_create_qp+0x3f6/0x5f0 drivers/infiniband/sw/rxe/rxe_verbs.c:583
>> ...
>> "
>> This is a use-before-initialization problem.
>>
>> In the following function
>> "
>> 291 /* called by the create qp verb */
>> 292 int rxe_qp_from_init(struct rxe_dev *rxe, struct rxe_qp *qp,
>> struct rxe_pd *pd,
>> 297 {
>> ...
>> 317 rxe_qp_init_misc(rxe, qp, init);
>> ...
>> 322
>> 323 err = rxe_qp_init_resp(rxe, qp, init, udata, uresp);
>> 324 if (err)
>> 325 goto err2; <--- error
>>
>> ...
>>
>> 334 err2:
>> 335 rxe_queue_cleanup(qp->sq.queue); <--- Goto here
>> 336 qp->sq.queue = NULL;
>> "
>> In rxe_qp_init_resp, the error occurs before skb_queue_head_init.
>> So this call trace appeared.
>>
>> Fixes: 8700e3e7c485 ("Soft RoCE driver")
>> Reported-by: syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com
>> Link: https://lore.kernel.org/lkml/000000000000235bce05fac5f850@google.com/T/
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
>> ---
>> V1->V2: Add Fixes and Link.
>> ---
>> drivers/infiniband/sw/rxe/rxe_qp.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> Applied to for-rc, thanks
Thanks.
Zhu Yanjun
>
> Jason
prev parent reply other threads:[~2023-06-09 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 3:54 [PATCH v2 1/1] RDMA/rxe: Fix the use-before-initialization error of resp_pkts Zhu Yanjun
2023-06-09 17:04 ` Jason Gunthorpe
2023-06-09 23:59 ` Zhu Yanjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b35e9a2-8ad5-cdc9-aef2-f1477ddda6eb@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=syzbot+eba589d8f49c73d356da@syzkaller.appspotmail.com \
--cc=yanjun.zhu@intel.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox