From: Gal Pressman <galpress@amazon.com>
To: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leonro@mellanox.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next 10/14] RDMA/restrack: Store all special QPs in restrack DB
Date: Wed, 26 Aug 2020 11:04:25 +0300 [thread overview]
Message-ID: <6de2c8a5-3608-29a2-ecc3-41cafb2ed0a7@amazon.com> (raw)
In-Reply-To: <20200824104415.1090901-11-leon@kernel.org>
On 24/08/2020 13:44, Leon Romanovsky wrote:
> diff --git a/drivers/infiniband/core/core_priv.h b/drivers/infiniband/core/core_priv.h
> index e84b0fedaacb..7c4752c47f80 100644
> --- a/drivers/infiniband/core/core_priv.h
> +++ b/drivers/infiniband/core/core_priv.h
> @@ -347,6 +347,8 @@ static inline struct ib_qp *_ib_create_qp(struct ib_device *dev,
> qp->srq = attr->srq;
> qp->rwq_ind_tbl = attr->rwq_ind_tbl;
> qp->event_handler = attr->event_handler;
> + qp->qp_type = attr->qp_type;
Already assigned above.
> + qp->port = attr->port_num;
If the assignment is moved here then it can be removed from ib_create_qp which
was added in the first patch.
Also, in the first patch it's surrounded by an if.
next prev parent reply other threads:[~2020-08-26 8:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 10:44 [PATCH rdma-next 00/14] Track memory allocation with restrack DB help Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 01/14] RDMA/verbs: Assign port number of special QPs Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 02/14] RDMA/cma: Delete from restrack DB after successful destroy Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 03/14] RDMA/mlx5: Don't call to restrack recursively Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 04/14] RDMA/restrack: Count references to the verbs objects Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 05/14] RDMA/restrack: Simplify restrack tracking in kernel flows Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 06/14] RDMA/restrack: Improve readability in task name management Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 07/14] RDMA/cma: Be strict with attaching to CMA device Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 08/14] RDMA/core: Allow drivers to disable restrack DB Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 09/14] RDMA/counter: Combine allocation and bind logic Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 10/14] RDMA/restrack: Store all special QPs in restrack DB Leon Romanovsky
2020-08-26 8:04 ` Gal Pressman [this message]
2020-08-26 8:27 ` Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 11/14] RDMA/restrack: Make restrack DB mandatory for IB objects Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 12/14] RDMA/restrack: Support all QP types Leon Romanovsky
2020-08-26 8:03 ` Gal Pressman
2020-08-26 8:13 ` Leon Romanovsky
2020-08-26 8:17 ` Gal Pressman
2020-08-24 10:44 ` [PATCH rdma-next 13/14] RDMA/core: Track device memory MRs Leon Romanovsky
2020-08-24 10:44 ` [PATCH rdma-next 14/14] RDMA/restrack: Drop valid restrack field as source of ambiguity Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de2c8a5-3608-29a2-ecc3-41cafb2ed0a7@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).