From: "Margolin, Michael" <mrgolin@amazon.com>
To: Gal Pressman <gal.pressman@linux.dev>, <jgg@nvidia.com>,
<leon@kernel.org>, <linux-rdma@vger.kernel.org>
Cc: <sleybo@amazon.com>, <matua@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Extend admin timeout error print
Date: Thu, 3 Jul 2025 15:20:53 +0300 [thread overview]
Message-ID: <73bc57f6-a791-4852-9fde-b82021e98372@amazon.com> (raw)
In-Reply-To: <bdbb1205-d940-434a-a102-b233562a1429@linux.dev>
On 7/3/2025 9:46 AM, Gal Pressman wrote:
> Arguably, there is no point in keeping the comp_ctx pointer print, as
> you have nothing to compare the hashed pointer to. It could've been
> useful if the pointer was also printed when the command is submitted,
> but it isn't, so it's probably better to just remove it and keep the
> index you added.
>
> A better alternative might be storing the cmd_id inside the comp_ctx and
> printing it instead, it contains more information.
Nice idea, doing that. Thanks.
Michael
prev parent reply other threads:[~2025-07-03 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 15:20 [PATCH for-next] RDMA/efa: Extend admin timeout error print Michael Margolin
2025-07-03 6:46 ` Gal Pressman
2025-07-03 12:20 ` Margolin, Michael [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73bc57f6-a791-4852-9fde-b82021e98372@amazon.com \
--to=mrgolin@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox