From: Saeed Mahameed <saeedm@nvidia.com>
To: "caihuoqing@baidu.com" <caihuoqing@baidu.com>,
"leon@kernel.org" <leon@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Make use of pr_warn()
Date: Mon, 9 Aug 2021 20:37:07 +0000 [thread overview]
Message-ID: <744a99a3de26300fc244d5b7702c87a9dd926e6e.camel@nvidia.com> (raw)
In-Reply-To: <YRECZn/N9qSQkhKu@unreal>
On Mon, 2021-08-09 at 13:24 +0300, Leon Romanovsky wrote:
> On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
>
[...]
> > - printk(KERN_WARNING "mlx5: can't set and
> > add to the same HW field (%x)\n", f->field);
> > + pr_warn("mlx5: can't set and add to the
> > same HW field (%x)\n", f->field);
>
> It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.
>
please use: netdev_warn(priv->netdev,
> > return -EOPNOTSUPP;
> > }
> >
> > @@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct
> > mlx5e_priv *priv,
> > if (first < next_z && next_z < last) {
> > NL_SET_ERR_MSG_MOD(extack,
> > "rewrite of few sub-
> > fields isn't supported");
> > - printk(KERN_WARNING "mlx5: rewrite of few
> > sub-fields (mask %lx) isn't offloaded\n",
> > - mask);
> > + pr_warn("mlx5: rewrite of few sub-fields
> > (mask %lx) isn't offloaded\n",
> > + mask);
>
> ditto
>
same
prev parent reply other threads:[~2021-08-09 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:08 [PATCH] net/mlx5e: Make use of pr_warn() Cai Huoqing
2021-08-09 10:24 ` Leon Romanovsky
2021-08-09 20:37 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744a99a3de26300fc244d5b7702c87a9dd926e6e.camel@nvidia.com \
--to=saeedm@nvidia.com \
--cc=caihuoqing@baidu.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox