From: Marcel Apfelbaum <marcel@redhat.com>
To: Moni Shoua <monis@mellanox.com>, Yuval Shaia <yuval.shaia@oracle.com>
Cc: linux-rdma <linux-rdma@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH] drivers/rxe: improve rxe loopback
Date: Thu, 27 Jul 2017 12:55:57 +0300 [thread overview]
Message-ID: <778dcc67-30f2-aecc-3e53-7cf4d0afb74e@redhat.com> (raw)
In-Reply-To: <CAG9sBKNbC=TzgMpSuiGwiBJo_ZX0eSoQfni2YRUHg9J96yNkww@mail.gmail.com>
On 27/07/2017 10:04, Moni Shoua wrote:
> On Wed, Jul 26, 2017 at 10:57 PM, Yuval Shaia <yuval.shaia@oracle.com> wrote:
>> On Wed, Jul 26, 2017 at 05:52:48PM +0300, Marcel Apfelbaum wrote:
>>> Currently a packet is marked for loopback only if the source and
>>> destination address match. This is not enough when multiple
>>> gids are present in rxe's gid table and the traffic is
>>> from one gid to another.
>>>
>>> Fix it by marking the packet for loopback if the destination
>>> address appears in rxe's gid table.
>>>
>>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>>
> Have you considered using ip_route_output_key() for IPv4 or
> ip6_route_output() for IPv6 to decide if this is a loopback?
> For reference you can check the flow starting at rdma_resolve_ip()
>
Hi Moni,
Yes, I had looked into it, but I haven't seen how I can find
out if the destination IP belongs to the same RXE.
The loopback flag will give us the "same host"
confirmation, but not the same rxe instance, right?
Any ideas would be welcomed.
Thanks,
Marcel
next prev parent reply other threads:[~2017-07-27 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 14:52 [PATCH] drivers/rxe: improve rxe loopback Marcel Apfelbaum
2017-07-26 19:36 ` Yuval Shaia
2017-07-26 19:56 ` Yuval Shaia
[not found] ` <20170726145248.21677-1-marcel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-26 19:57 ` Yuval Shaia
2017-07-27 7:04 ` Moni Shoua
2017-07-27 9:55 ` Marcel Apfelbaum [this message]
[not found] ` <778dcc67-30f2-aecc-3e53-7cf4d0afb74e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-30 9:57 ` Moni Shoua
[not found] ` <CAG9sBKNc89nVeJM-UZk8JRy9zXz-U1JdWJ8KkjpeSXvdbwNNsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-31 9:53 ` Marcel Apfelbaum
2017-07-27 7:36 ` Leon Romanovsky
[not found] ` <20170727073635.GB13672-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-07-27 9:49 ` Marcel Apfelbaum
[not found] ` <52aeac10-079f-5c3b-5987-14ead00e2646-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-27 10:40 ` Leon Romanovsky
2017-07-27 13:47 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778dcc67-30f2-aecc-3e53-7cf4d0afb74e@redhat.com \
--to=marcel@redhat.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox