From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adit Ranadive Subject: Re: [PATCH] vmw_pvrdma: Avoid rounding up of sge count to power of 2 Date: Fri, 16 Feb 2018 10:27:02 -0800 Message-ID: <7a727517-7f46-e691-4547-b253acf48545@vmware.com> References: <1518741592-12723-1-git-send-email-aditr@vmware.com> <20180216072216.GK2197@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180216072216.GK2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 2/15/18 11:22 PM, Leon Romanovsky wrote: > On Thu, Feb 15, 2018 at 04:39:52PM -0800, Adit Ranadive wrote: >> Creation of resources can fail if the rounding up exceeds >> provider supported values. >> >> Fixes: 4c8ed14eb6b7 ("vmw_pvrdma: Add SRQ support") >> Reviewed-by: Bryan Tan >> Reviewed-by: Nitish Bhat >> Signed-off-by: Adit Ranadive >> Cc: stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org >> --- >> providers/vmw_pvrdma/qp.c | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/providers/vmw_pvrdma/qp.c b/providers/vmw_pvrdma/qp.c >> index efcc99b..4b9f897 100644 >> --- a/providers/vmw_pvrdma/qp.c >> +++ b/providers/vmw_pvrdma/qp.c >> @@ -113,7 +113,7 @@ struct ibv_srq *pvrdma_create_srq(struct ibv_pd *pd, >> int ret; >> >> attr->attr.max_wr = align_next_power2(max_t(uint32_t, 1U, attr->attr.max_wr)); >> - attr->attr.max_sge = align_next_power2(max_t(uint32_t, 1U, attr->attr.max_sge)); >> + attr->attr.max_sge = max_t(uint32_t, 1U, attr->attr.max_sge); > > One of two: or your commit message is not correct and you should mention > that align_next_power2() is not needed, or your code is incorrect, > because user can provide large enough number and this call will fail > anyway. Sorry, that's a terrible commit message. Yeah the align_next_power2 is extraneous. Will send v1 out with updated message. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html