From: Moshe Shemesh <moshe@nvidia.com>
To: 赵晨光 <zhaochenguang@kylinos.cn>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: netdev <netdev@vger.kernel.org>, linux-rdma <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v3] net/mlx5: Flag state up only after cmdif is ready
Date: Thu, 5 Jun 2025 11:14:46 +0300 [thread overview]
Message-ID: <7a8e85ea-7ce3-4da4-bb0b-819fe9f7d54b@nvidia.com> (raw)
In-Reply-To: <1l92ogj6wlz-1l96i9zg23c@nsmail7.0.0--kylin--1>
On 6/4/2025 6:07 AM, 赵晨光 wrote:
>
> The trace points to cmdif, that's why we better handle it there.
> I couldn't reproduce it using the scripts above, what is the
> reproduction frequency ? can you send me the whole log of reproduction ?
> See the attachment for all logs.
> Thanks!
Thanks for the logs and the data.
As I see, this is a reproduction on old OFED 4.7-3.2.9 driver, while on
new upstream driver we have mlx5_cmdif_state checked in cmd_exec() which
means to avoid such trace by setting mlx5_cmdif_state down on
mlx5_function_teardown() and up only after mlx5_cmd_enable() which do
create_msg_cache(). You can also check on latest OFED and if issue
reproduced there, please take it with Nvidia support. If you have
reproduction on latest upstream kernel driver, please send the
reproduction log and we can continue here till resolved upstream.
next parent reply other threads:[~2025-06-05 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1l92ogj6wlz-1l96i9zg23c@nsmail7.0.0--kylin--1>
2025-06-05 8:14 ` Moshe Shemesh [this message]
2025-06-03 6:14 [PATCH v3] net/mlx5: Flag state up only after cmdif is ready Chenguang Zhao
2025-06-03 17:25 ` Moshe Shemesh
2025-06-05 9:19 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a8e85ea-7ce3-4da4-bb0b-819fe9f7d54b@nvidia.com \
--to=moshe@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox