From: Roi Dayan <roid@nvidia.com>
To: zhang.songyi@zte.com.cn, leon@kernel.org
Cc: saeedm@nvidia.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, kliteyn@nvidia.com,
shunh@nvidia.com, rongweil@nvidia.com, valex@nvidia.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: remove redundant ret variable
Date: Mon, 5 Dec 2022 10:10:28 +0200 [thread overview]
Message-ID: <7eea41f2-ef05-ab5d-0191-d155ccdfb5e0@nvidia.com> (raw)
In-Reply-To: <202212051424013653827@zte.com.cn>
On 05/12/2022 8:24, zhang.songyi@zte.com.cn wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return value from mlx5dr_send_postsend_action() directly instead of taking
> this in another redundant variable.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> index a4476cb4c3b3..fd2d31cdbcf9 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> @@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
> struct mlx5dr_action *action)
> {
> struct postsend_info send_info = {};
> - int ret;
>
> send_info.write.addr = (uintptr_t)action->rewrite->data;
> send_info.write.length = action->rewrite->num_of_actions *
> @@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
> mlx5dr_icm_pool_get_chunk_mr_addr(action->rewrite->chunk);
> send_info.rkey = mlx5dr_icm_pool_get_chunk_rkey(action->rewrite->chunk);
>
> - ret = dr_postsend_icm_data(dmn, &send_info);
> -
> - return ret;
> + return dr_postsend_icm_data(dmn, &send_info);
> }
>
> static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,
Reviewed-by: Roi Dayan <roid@nvidia.com>
next prev parent reply other threads:[~2022-12-05 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 6:24 [PATCH net-next] net/mlx5: remove redundant ret variable zhang.songyi
2022-12-05 8:10 ` Roi Dayan [this message]
2022-12-06 13:21 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eea41f2-ef05-ab5d-0191-d155ccdfb5e0@nvidia.com \
--to=roid@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rongweil@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shunh@nvidia.com \
--cc=valex@nvidia.com \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox