Re: [PATCH rdma-core 4/5] buildlib: run ABI check in travis-build

[Nicolas Morey-Chaisemartin <NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org>]

Le 15/11/2017 à 18:34, Leon Romanovsky a écrit :
> On Wed, Nov 15, 2017 at 06:24:32PM +0100, Nicolas Morey-Chaisemartin wrote:
>>
>> Le 15/11/2017 à 06:58, Leon Romanovsky a écrit :
>>> On Tue, Nov 14, 2017 at 07:58:06PM +0100, Nicolas Morey-Chaisemartin wrote:
>>>> Run travis-checkabi during travis build
>>>>
>>>> Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin-IBi9RG/b67k@public.gmane.org>
>>>> Cc: stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org # v15
>>>> ---
>>>>  buildlib/travis-build | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/buildlib/travis-build b/buildlib/travis-build
>>>> index bf86baa7..f8e5ee05 100755
>>>> --- a/buildlib/travis-build
>>>> +++ b/buildlib/travis-build
>>>> @@ -5,6 +5,10 @@ set -e
>>>>  # Echo all commands to Travis log
>>>>  set -x
>>>>
>>>> +
>>>> +# Build in debug mode and check the ABI against the ref
>>>> +./buildlib/travis-checkabi
>>> Will it run for all commits, including master?
>> Yes and no.
>> The script is called for all commits. But one of the first thing it does is checking that reference file exists and ignore if they don't (see Patch 3):
>>
>> +# No reference ABI to match against.
>> +if [ ! -d $REF_DIR ]; then
>> +	echo "INFO: Skipping ABI check. No reference available"
>> +	exit 0
>> +fi
>> +
>>
>> It might be worth doing this test first in the script to avoid the debug build / abi-dumper calls.
> Yes, please.
>
> Thanks
>
>

Fixed in the github PR.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html