From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue() Date: Wed, 26 Oct 2016 20:05:14 -0700 Message-ID: <8404f2d1-5bc3-6c84-7ca0-24e7672ff67d@acm.org> References: <5143c240-39af-9fe2-d3e6-ed69f9c20531@sandisk.com> <7690b469-f5b7-ab04-4b6f-fa0d679e0f18@acm.org> <16074653-5e31-27b0-90db-33d36a9df0bc@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , James Bottomley , "Martin K. Petersen" , Mike Snitzer , Doug Ledford , Keith Busch , Laurence Oberman , "linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 10/26/16 19:48, Ming Lei wrote: > On Thu, Oct 27, 2016 at 10:40 AM, Bart Van Assche wrote: >> If you have a look at the later patches in this series then you will see >> that the dm core and the NVMe driver have been modified such that >> blk_mq_stop_hw_queues(q) is called immediately before >> blk_mq_quiesce_queue(q) is called. > > Cause any current and future users of blk_mq_quiesce_queue(q) > have to set the flag via blk_mq_stop_hw_queues(q), why not set > the flag explicitly in blk_mq_quiesce_queue(q)? Hello Ming, I'll leave it to Jens to decide whether I should repost the patch series with this change integrated or whether to realize this change with a follow-up patch. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html